Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1164633002: /infra directory (Closed)

Created:
5 years, 6 months ago by nodir
Modified:
5 years, 6 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

/infra directory Added /infra directory, it will contain chrome-infra specific files, in particular configs for chrome infra services. /infra/project-config/cr-buildbucket.cfg defines buckets on cr-buildbucket.appspot.com R=borenet@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/038b01c081d16e3e3ec3e874c816ee866ab73508

Patch Set 1 : #

Total comments: 5

Patch Set 2 : updated owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
A infra/OWNERS View 1 1 chunk +4 lines, -0 lines 0 comments Download
A infra/README View 1 chunk +1 line, -0 lines 0 comments Download
A infra/project-config/README View 1 chunk +1 line, -0 lines 0 comments Download
A infra/project-config/cr-buildbucket.cfg View 1 chunk +71 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nodir
PTAL
5 years, 6 months ago (2015-05-29 18:20:26 UTC) #3
borenet
https://codereview.chromium.org/1164633002/diff/40001/infra/OWNERS File infra/OWNERS (right): https://codereview.chromium.org/1164633002/diff/40001/infra/OWNERS#newcode1 infra/OWNERS:1: borenet@chromium.org Please add jcgregorio, rmistry, and stephana. https://codereview.chromium.org/1164633002/diff/40001/infra/project-config/cr-buildbucket.cfg File ...
5 years, 6 months ago (2015-05-29 18:31:03 UTC) #4
nodir
https://codereview.chromium.org/1164633002/diff/40001/infra/OWNERS File infra/OWNERS (right): https://codereview.chromium.org/1164633002/diff/40001/infra/OWNERS#newcode1 infra/OWNERS:1: borenet@chromium.org On 2015/05/29 18:31:03, borenet wrote: > Please add ...
5 years, 6 months ago (2015-06-01 16:04:09 UTC) #5
borenet
LGTM https://codereview.chromium.org/1164633002/diff/40001/infra/project-config/cr-buildbucket.cfg File infra/project-config/cr-buildbucket.cfg (right): https://codereview.chromium.org/1164633002/diff/40001/infra/project-config/cr-buildbucket.cfg#newcode1 infra/project-config/cr-buildbucket.cfg:1: # Defines buckets on cr-buildbucket.appspot.com, used to schedule ...
5 years, 6 months ago (2015-06-01 16:33:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164633002/60001
5 years, 6 months ago (2015-06-01 16:33:57 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 16:39:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://skia.googlesource.com/skia/+/038b01c081d16e3e3ec3e874c816ee866ab73508

Powered by Google App Engine
This is Rietveld 408576698