Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 1164613002: DevTools: Simplify firstFrameAfterCommit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressing comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/components_lazy/FilmStripModel.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1029 matching lines...) Expand 10 before | Expand all | Expand 10 after
1040 WebInspector.TimelineUIUtils.buildTraceEventDetails(event, this._mod el, this._detailsLinkifier, this._appendDetailsTabsForTraceEventAndShowDetails.b ind(this, event)); 1040 WebInspector.TimelineUIUtils.buildTraceEventDetails(event, this._mod el, this._detailsLinkifier, this._appendDetailsTabsForTraceEventAndShowDetails.b ind(this, event));
1041 break; 1041 break;
1042 case WebInspector.TimelineSelection.Type.TraceEvent: 1042 case WebInspector.TimelineSelection.Type.TraceEvent:
1043 var event = /** @type {!WebInspector.TracingModel.Event} */ (this._s election.object()); 1043 var event = /** @type {!WebInspector.TracingModel.Event} */ (this._s election.object());
1044 WebInspector.TimelineUIUtils.buildTraceEventDetails(event, this._mod el, this._detailsLinkifier, this._appendDetailsTabsForTraceEventAndShowDetails.b ind(this, event)); 1044 WebInspector.TimelineUIUtils.buildTraceEventDetails(event, this._mod el, this._detailsLinkifier, this._appendDetailsTabsForTraceEventAndShowDetails.b ind(this, event));
1045 break; 1045 break;
1046 case WebInspector.TimelineSelection.Type.Frame: 1046 case WebInspector.TimelineSelection.Type.Frame:
1047 var frame = /** @type {!WebInspector.TimelineFrame} */ (this._select ion.object()); 1047 var frame = /** @type {!WebInspector.TimelineFrame} */ (this._select ion.object());
1048 if (Runtime.experiments.isEnabled("filmStripInNetworkAndTimeline") & & !this._filmStripModel) 1048 if (Runtime.experiments.isEnabled("filmStripInNetworkAndTimeline") & & !this._filmStripModel)
1049 this._filmStripModel = new WebInspector.FilmStripModel(this._tra cingModel); 1049 this._filmStripModel = new WebInspector.FilmStripModel(this._tra cingModel);
1050 var filmStripFrame = this._filmStripModel && this._filmStripModel.fi rstFrameAfterCommit(frame.endTime); 1050 var filmStripFrame = this._filmStripModel && this._filmStripModel.fr ameByTimestamp(frame.endTime);
1051 if (filmStripFrame && filmStripFrame.timestamp - frame.endTime > 10)
1052 filmStripFrame = null;
1051 this.showInDetails(WebInspector.TimelineUIUtils.generateDetailsConte ntForFrame(this._lazyFrameModel, frame, filmStripFrame)); 1053 this.showInDetails(WebInspector.TimelineUIUtils.generateDetailsConte ntForFrame(this._lazyFrameModel, frame, filmStripFrame));
1052 if (frame.layerTree) { 1054 if (frame.layerTree) {
1053 var layersView = this._layersView(); 1055 var layersView = this._layersView();
1054 layersView.showLayerTree(frame.layerTree, frame.paints); 1056 layersView.showLayerTree(frame.layerTree, frame.paints);
1055 if (!this._detailsView.hasTab(WebInspector.TimelinePanel.Details Tab.LayerViewer)) 1057 if (!this._detailsView.hasTab(WebInspector.TimelinePanel.Details Tab.LayerViewer))
1056 this._detailsView.appendTab(WebInspector.TimelinePanel.Detai lsTab.LayerViewer, WebInspector.UIString("Layers"), layersView); 1058 this._detailsView.appendTab(WebInspector.TimelinePanel.Detai lsTab.LayerViewer, WebInspector.UIString("Layers"), layersView);
1057 } 1059 }
1058 break; 1060 break;
1059 case WebInspector.TimelineSelection.Type.Range: 1061 case WebInspector.TimelineSelection.Type.Range:
1060 this._updateSelectedRangeStats(this._selection._startTime, this._sel ection._endTime); 1062 this._updateSelectedRangeStats(this._selection._startTime, this._sel ection._endTime);
(...skipping 775 matching lines...) Expand 10 before | Expand all | Expand 10 after
1836 /** 1838 /**
1837 * @override 1839 * @override
1838 */ 1840 */
1839 reset: function() 1841 reset: function()
1840 { 1842 {
1841 this._filmStripView.reset(); 1843 this._filmStripView.reset();
1842 }, 1844 },
1843 1845
1844 __proto__: WebInspector.TimelineOverviewBase.prototype 1846 __proto__: WebInspector.TimelineOverviewBase.prototype
1845 } 1847 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/components_lazy/FilmStripModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698