Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(169)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1164613002: DevTools: Simplify firstFrameAfterCommit. (Closed)

Created:
4 years, 11 months ago by alph
Modified:
4 years, 10 months ago
Reviewers:
caseq, pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Simplify firstFrameAfterCommit. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196773

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M Source/devtools/front_end/components_lazy/FilmStripModel.js View 1 1 chunk +11 lines, -12 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
alph
4 years, 11 months ago (2015-05-29 13:46:04 UTC) #2
alph
4 years, 10 months ago (2015-06-09 13:15:31 UTC) #4
yurys
https://codereview.chromium.org/1164613002/diff/1/Source/devtools/front_end/components_lazy/FilmStripModel.js File Source/devtools/front_end/components_lazy/FilmStripModel.js (right): https://codereview.chromium.org/1164613002/diff/1/Source/devtools/front_end/components_lazy/FilmStripModel.js#newcode68 Source/devtools/front_end/components_lazy/FilmStripModel.js:68: var index = this._frames.upperBound(timestamp, comparator) - 1; lowerBound?
4 years, 10 months ago (2015-06-09 13:22:37 UTC) #5
alph
https://codereview.chromium.org/1164613002/diff/1/Source/devtools/front_end/components_lazy/FilmStripModel.js File Source/devtools/front_end/components_lazy/FilmStripModel.js (right): https://codereview.chromium.org/1164613002/diff/1/Source/devtools/front_end/components_lazy/FilmStripModel.js#newcode68 Source/devtools/front_end/components_lazy/FilmStripModel.js:68: var index = this._frames.upperBound(timestamp, comparator) - 1; On 2015/06/09 ...
4 years, 10 months ago (2015-06-09 13:26:38 UTC) #6
yurys
lgtm
4 years, 10 months ago (2015-06-09 13:27:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164613002/20001
4 years, 10 months ago (2015-06-09 13:28:35 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 15:25:08 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196773

Powered by Google App Engine
This is Rietveld 408576698