Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2425)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 1164603003: Remove ExtensionPrefs::SetDidExtensionEscalatePermissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sync_permission_approval
Patch Set: review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | extensions/browser/extension_prefs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 07ab1658cf38975be6e0c02b95970a1737b195f5..919f925b850cb99871f49fcaad7dadaa5906fe97 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -2760,8 +2760,6 @@ TEST_F(ExtensionServiceTest, UpdateExtensionPreservesState) {
// over to the updated version.
service()->DisableExtension(good->id(), Extension::DISABLE_USER_ACTION);
extensions::util::SetIsIncognitoEnabled(good->id(), profile(), true);
- ExtensionPrefs::Get(profile())
- ->SetDidExtensionEscalatePermissions(good, true);
path = data_dir().AppendASCII("good2.crx");
UpdateExtension(good_crx, path, INSTALLED);
@@ -2769,8 +2767,8 @@ TEST_F(ExtensionServiceTest, UpdateExtensionPreservesState) {
const Extension* good2 = service()->GetExtensionById(good_crx, true);
ASSERT_EQ("1.0.0.1", good2->version()->GetString());
EXPECT_TRUE(extensions::util::IsIncognitoEnabled(good2->id(), profile()));
- EXPECT_TRUE(ExtensionPrefs::Get(profile())
- ->DidExtensionEscalatePermissions(good2->id()));
+ EXPECT_EQ(Extension::DISABLE_USER_ACTION,
+ ExtensionPrefs::Get(profile())->GetDisableReasons(good2->id()));
}
// Tests that updating preserves extension location.
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | extensions/browser/extension_prefs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698