chrome/browser/apps/ephemeral_app_launcher_browsertest.cc - Issue 1164603003: Remove ExtensionPrefs::SetDidExtensionEscalatePermissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_launcher_browsertest.cc

Issue 1164603003: Remove ExtensionPrefs::SetDidExtensionEscalatePermissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sync_permission_approval

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/ephemeral_app_browsertest.cc ('k') | chrome/browser/extensions/extension_prefs_unittest.cc » ('j') | chrome/browser/extensions/extension_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/ephemeral_app_launcher_browsertest.cc

diff --git a/chrome/browser/apps/ephemeral_app_launcher_browsertest.cc b/chrome/browser/apps/ephemeral_app_launcher_browsertest.cc

index 5affa8a469e31ed60c038b9bcec905cf822787a1..63e6bc966862ab7fd025b71c5424d918c48ee44b 100644

--- a/chrome/browser/apps/ephemeral_app_launcher_browsertest.cc

+++ b/chrome/browser/apps/ephemeral_app_launcher_browsertest.cc

@@ -287,13 +287,6 @@ class EphemeralAppLauncherTest : public WebstoreInstallerTest {

ExtensionSystem::Get(profile())->extension_service();

service->DisableExtension(app->id(), disable_reason);

- if (disable_reason == Extension::DISABLE_PERMISSIONS_INCREASE) {

- // When an extension is disabled due to a permissions increase, this

- // flag needs to be set too, for some reason.

- ExtensionPrefs::Get(profile())

- ->SetDidExtensionEscalatePermissions(app, true);

- }

EXPECT_TRUE(

ExtensionRegistry::Get(profile())->disabled_extensions().Contains(

app->id()));