Issue 1164603002: [turbofan] Clean up cctest "framework" for dealing with native calls.

Issue 1164603002: [turbofan] Clean up cctest "framework" for dealing with native calls. (Closed)

Created:
5 years, 6 months ago by titzer

Modified:
5 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Clean up cctest "framework" for dealing with native calls. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/30ef6b7a693a468a8d336332bbfae32b20585505 Cr-Commit-Position: refs/heads/master@{#28703}

Patch Set 2 : #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -190 lines)			Patch
M	src/compiler/raw-machine-assembler.h	View	1	2 chunks	+11 lines, -9 lines	0 comments	Download
M	test/cctest/compiler/call-tester.h	View		7 chunks	+55 lines, -111 lines	0 comments	Download
M	test/cctest/compiler/codegen-tester.h	View		2 chunks	+36 lines, -60 lines	0 comments	Download
M	test/cctest/compiler/graph-builder-tester.h	View		4 chunks	+30 lines, -9 lines	0 comments	Download
M	test/cctest/compiler/test-run-machops.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/1164603002/diff/1/src/compiler/raw-machine-assembler.h File src/compiler/raw-machine-assembler.h (right): https://codereview.chromium.org/1164603002/diff/1/src/compiler/raw-machine-assembler.h#newcode458 src/compiler/raw-machine-assembler.h:458: nit: One empty newline oughta be enough for ...

5 years, 6 months ago (2015-05-29 13:16:48 UTC) #2

titzer

https://codereview.chromium.org/1164603002/diff/1/src/compiler/raw-machine-assembler.h File src/compiler/raw-machine-assembler.h (right): https://codereview.chromium.org/1164603002/diff/1/src/compiler/raw-machine-assembler.h#newcode458 src/compiler/raw-machine-assembler.h:458: On 2015/05/29 13:16:48, Michael Starzinger wrote: > nit: One ...

5 years, 6 months ago (2015-05-29 13:18:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164603002/20001

5 years, 6 months ago (2015-05-29 13:19:08 UTC) #6

commit-bot: I haz the power

5 years, 6 months ago (2015-05-29 14:06:02 UTC) #8

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/30ef6b7a693a468a8d336332bbfae32b20585505
Cr-Commit-Position: refs/heads/master@{#28703}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages