Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1958)

Unified Diff: Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/canvas2d/CanvasRenderingContext2DState.h ('k') | Source/platform/heap/ThreadState.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
diff --git a/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp b/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
index 48c12d2a81ad265e7d406ccff9cd3309585dca71..4e3b311269f23a85d2ebc25f3ba2e1e74fdd28d0 100644
--- a/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
+++ b/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
@@ -341,7 +341,7 @@ SkImageFilter* CanvasRenderingContext2DState::getFilter(Element* styleResolution
// TODO(junov): crbug.com/502877 Feed m_fillStyle and m_strokeStyle into FillPaint and
// StrokePaint respectively for filters that reference SVG.
- StyleBuilder::applyProperty(CSSPropertyWebkitFilter, resolverState, m_filterValue.get());
+ StyleBuilder::applyProperty(CSSPropertyWebkitFilter, resolverState, *m_filterValue);
RefPtrWillBeRawPtr<FilterEffectBuilder> filterEffectBuilder = FilterEffectBuilder::create();
const float effectiveZoom = 1.0f; // Deliberately ignore zoom on the canvas element
filterEffectBuilder->build(styleResolutionHost, filterStyle->filter(), effectiveZoom);
@@ -434,7 +434,7 @@ void CanvasRenderingContext2DState::setShadowColor(SkColor shadowColor)
shadowParameterChanged();
}
-void CanvasRenderingContext2DState::setFilter(PassRefPtrWillBeRawPtr<CSSValue> filterValue)
+void CanvasRenderingContext2DState::setFilter(CSSValue filterValue)
{
m_filterValue = filterValue;
m_resolvedFilter.clear();
« no previous file with comments | « Source/modules/canvas2d/CanvasRenderingContext2DState.h ('k') | Source/platform/heap/ThreadState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698