Source/core/style/StyleFetchedImageSet.h - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/style/StyleFetchedImageSet.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/style/StyleFetchedImageSet.h

diff --git a/Source/core/style/StyleFetchedImageSet.h b/Source/core/style/StyleFetchedImageSet.h

index 3faf1067584a0f5a8bb6d250bfe761c0030f0f99..08b8de0d4fab48524377db6ee2484e07e557b10c 100644

--- a/Source/core/style/StyleFetchedImageSet.h

+++ b/Source/core/style/StyleFetchedImageSet.h

@@ -47,7 +47,7 @@ public:

}

virtual ~StyleFetchedImageSet();

- virtual PassRefPtrWillBeRawPtr<CSSValue> cssValue() const override;

+ virtual NullableCSSValue cssValue() const override;

// FIXME: This is used by StyleImage for equals comparison, but this implementation

// only looks at the image from the set that we have loaded. I'm not sure if that is

« no previous file with comments | « Source/core/style/StyleFetchedImage.cpp ('k') | Source/core/style/StyleFetchedImageSet.cpp » ('j') | no next file with comments »