Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: Source/core/dom/Element.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/resolver/ViewportStyleResolver.cpp ('k') | Source/core/dom/TextLinkColors.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index 55b420d59d027efcb3916839c8f417267efa3cd8..897fcf568893a49dee2a241f6cf98e291076cf36 100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -3047,7 +3047,7 @@ static bool needsURLResolutionForInlineStyle(const Element& element, const Docum
return false;
for (unsigned i = 0; i < style->propertyCount(); ++i) {
// FIXME: Should handle all URL-based properties: CSSImageSetValue, CSSCursorImageValue, etc.
- if (style->propertyAt(i).value()->isImageValue())
+ if (style->propertyAt(i).value().isImageValue())
return true;
}
return false;
@@ -3058,8 +3058,8 @@ static void reResolveURLsInInlineStyle(const Document& document, MutableStylePro
for (unsigned i = 0; i < style.propertyCount(); ++i) {
StylePropertySet::PropertyReference property = style.propertyAt(i);
// FIXME: Should handle all URL-based properties: CSSImageSetValue, CSSCursorImageValue, etc.
- if (property.value()->isImageValue())
- toCSSImageValue(property.value())->reResolveURL(document);
+ if (property.value().isImageValue())
+ toCSSImageValue(property.value()).reResolveURL(document);
}
}
« no previous file with comments | « Source/core/css/resolver/ViewportStyleResolver.cpp ('k') | Source/core/dom/TextLinkColors.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698