Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: Source/core/css/parser/CSSPropertyParserTest.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/parser/CSSPropertyParser.cpp ('k') | Source/core/css/parser/SizesCalcParserTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParserTest.cpp
diff --git a/Source/core/css/parser/CSSPropertyParserTest.cpp b/Source/core/css/parser/CSSPropertyParserTest.cpp
index dc58ef3e9f609b957764f3feb1df5b032394f969..661b1a27822212cbf3d988ee89cede2b4b5310ea 100644
--- a/Source/core/css/parser/CSSPropertyParserTest.cpp
+++ b/Source/core/css/parser/CSSPropertyParserTest.cpp
@@ -16,7 +16,7 @@ static unsigned computeNumberOfTracks(CSSValueList* valueList)
{
unsigned numberOfTracks = 0;
for (auto& value : *valueList) {
- if (value->isGridLineNamesValue())
+ if (value.isGridLineNamesValue())
continue;
++numberOfTracks;
}
@@ -49,10 +49,10 @@ TEST(CSSPropertyParserTest, GridTrackLimits)
};
for (unsigned i = 0; i < WTF_ARRAY_LENGTH(testCases); ++i) {
- RefPtrWillBeRawPtr<CSSValue> value = CSSParser::parseSingleValue(testCases[i].propertyID, testCases[i].input);
+ NullableCSSValue value = CSSParser::parseSingleValue(testCases[i].propertyID, testCases[i].input);
ASSERT_TRUE(value);
ASSERT_TRUE(value->isValueList());
- EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value.get())), testCases[i].output);
+ EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), testCases[i].output);
}
}
« no previous file with comments | « Source/core/css/parser/CSSPropertyParser.cpp ('k') | Source/core/css/parser/SizesCalcParserTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698