Source/core/css/parser/CSSParser.h - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParser.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/parser/CSSParser.h

diff --git a/Source/core/css/parser/CSSParser.h b/Source/core/css/parser/CSSParser.h

index ed29adad8100298e4b109c0f1756fdc70b882277..f61da5a0e0d938c591fb3dd4b97310a69c023fae 100644

--- a/Source/core/css/parser/CSSParser.h

+++ b/Source/core/css/parser/CSSParser.h

@@ -36,9 +36,9 @@ public:

static bool parseValue(MutableStylePropertySet*, CSSPropertyID unresolvedProperty, const String&, bool important, CSSParserMode, StyleSheetContents*);

// This is for non-shorthands only

- static PassRefPtrWillBeRawPtr<CSSValue> parseSingleValue(CSSPropertyID, const String&, const CSSParserContext& = strictCSSParserContext());

+ static NullableCSSValue parseSingleValue(CSSPropertyID, const String&, const CSSParserContext& = strictCSSParserContext());

- static PassRefPtrWillBeRawPtr<CSSValue> parseFontFaceDescriptor(CSSPropertyID, const String&, const CSSParserContext&);

+ static NullableCSSValue parseFontFaceDescriptor(CSSPropertyID, const String&, const CSSParserContext&);

static PassRefPtrWillBeRawPtr<ImmutableStylePropertySet> parseInlineStyleDeclaration(const String&, Element*);

« no previous file with comments | « Source/core/css/StylePropertySet.cpp ('k') | Source/core/css/parser/CSSParser.cpp » ('j') | no next file with comments »