Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: Source/core/css/RuleFeature.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/PropertySetCSSStyleDeclaration.cpp ('k') | Source/core/css/StylePropertySerializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/RuleFeature.cpp
diff --git a/Source/core/css/RuleFeature.cpp b/Source/core/css/RuleFeature.cpp
index a43cb3edadf21afed83eed2ba0d4f765cfb923cd..25087c5dac9b421c40f0168186eca47ab5b95bde 100644
--- a/Source/core/css/RuleFeature.cpp
+++ b/Source/core/css/RuleFeature.cpp
@@ -305,18 +305,18 @@ void RuleFeatureSet::updateInvalidationSetsForContentAttribute(const RuleData& r
return;
StylePropertySet::PropertyReference contentProperty = propertySet.propertyAt(propertyIndex);
- CSSValue* contentValue = contentProperty.value();
+ CSSValue contentValue = contentProperty.value();
- if (!contentValue->isValueList())
+ if (!contentValue.isValueList())
return;
- for (auto& item : toCSSValueList(*contentValue)) {
- if (!item->isPrimitiveValue())
+ for (auto& item : toCSSValueList(contentValue)) {
+ if (!item.isPrimitiveValue())
continue;
- CSSPrimitiveValue* primitiveItem = toCSSPrimitiveValue(item.get());
- if (!primitiveItem->isAttr())
+ CSSPrimitiveValue& primitiveItem = toCSSPrimitiveValue(item);
+ if (!primitiveItem.isAttr())
continue;
- ensureAttributeInvalidationSet(AtomicString(primitiveItem->getStringValue()));
+ ensureAttributeInvalidationSet(AtomicString(primitiveItem.getStringValue()));
}
}
« no previous file with comments | « Source/core/css/PropertySetCSSStyleDeclaration.cpp ('k') | Source/core/css/StylePropertySerializer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698