Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: Source/core/css/ComputedStyleCSSValueMapping.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSValueTestHelper.h ('k') | Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/ComputedStyleCSSValueMapping.h
diff --git a/Source/core/css/ComputedStyleCSSValueMapping.h b/Source/core/css/ComputedStyleCSSValueMapping.h
index 76764c17212b5558688ae3c2257b97e7ed2de3f2..5c392a46dddb513b62122445f55a37e5ee711a16 100644
--- a/Source/core/css/ComputedStyleCSSValueMapping.h
+++ b/Source/core/css/ComputedStyleCSSValueMapping.h
@@ -21,13 +21,13 @@ class Node;
class ComputedStyleCSSValueMapping {
public:
// FIXME: Resolve computed auto alignment in applyProperty/ComputedStyle and remove this non-const styledNode parameter.
- static PassRefPtrWillBeRawPtr<CSSValue> get(CSSPropertyID, const ComputedStyle&, const LayoutObject* = nullptr, Node* styledNode = nullptr, bool allowVisitedStyle = false);
+ static NullableCSSValue get(CSSPropertyID, const ComputedStyle&, const LayoutObject* = nullptr, Node* styledNode = nullptr, bool allowVisitedStyle = false);
private:
static PassRefPtrWillBeRawPtr<CSSPrimitiveValue> currentColorOrValidColor(const ComputedStyle&, const StyleColor&);
- static PassRefPtrWillBeRawPtr<CSSValue> valueForShadowData(const ShadowData&, const ComputedStyle&, bool useSpread);
- static PassRefPtrWillBeRawPtr<CSSValue> valueForShadowList(const ShadowList*, const ComputedStyle&, bool useSpread);
- static PassRefPtrWillBeRawPtr<CSSValue> valueForFilter(const ComputedStyle&);
- static PassRefPtrWillBeRawPtr<CSSValue> valueForFont(const ComputedStyle&);
+ static CSSValue valueForShadowData(const ShadowData&, const ComputedStyle&, bool useSpread);
+ static CSSValue valueForShadowList(const ShadowList*, const ComputedStyle&, bool useSpread);
+ static CSSValue valueForFilter(const ComputedStyle&);
+ static CSSValue valueForFont(const ComputedStyle&);
};
} // namespace blink
« no previous file with comments | « Source/core/css/CSSValueTestHelper.h ('k') | Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698