Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: Source/core/css/CSSPrimitiveValue.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSPathValue.cpp ('k') | Source/core/css/CSSPrimitiveValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSPrimitiveValue.h
diff --git a/Source/core/css/CSSPrimitiveValue.h b/Source/core/css/CSSPrimitiveValue.h
index 3f7b65ed10fa47ffdcee0ea063f26b3bc7687402..272fc24f553af70d11fa0477d950915a2a884abe 100644
--- a/Source/core/css/CSSPrimitiveValue.h
+++ b/Source/core/css/CSSPrimitiveValue.h
@@ -70,7 +70,7 @@ template<> inline float roundForImpreciseConversion(double value)
// CSSPrimitiveValues are immutable. This class has manual ref-counting
// of unioned types and does not have the code necessary
// to handle any kind of mutations.
-class CORE_EXPORT CSSPrimitiveValue : public CSSValue {
+class CORE_EXPORT CSSPrimitiveValue : public CSSValueObject {
public:
enum UnitType {
CSS_UNKNOWN = 0,
@@ -317,13 +317,13 @@ private:
template<typename T> CSSPrimitiveValue(T); // Defined in CSSPrimitiveValueMappings.h
template<typename T> CSSPrimitiveValue(T* val)
- : CSSValue(PrimitiveClass)
+ : CSSValueObject(PrimitiveClass)
{
init(PassRefPtrWillBeRawPtr<T>(val));
}
template<typename T> CSSPrimitiveValue(PassRefPtrWillBeRawPtr<T> val)
- : CSSValue(PrimitiveClass)
+ : CSSValueObject(PrimitiveClass)
{
init(val);
}
« no previous file with comments | « Source/core/css/CSSPathValue.cpp ('k') | Source/core/css/CSSPrimitiveValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698