Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: Source/core/css/CSSComputedStyleDeclaration.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSCalculationValueTest.cpp ('k') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSComputedStyleDeclaration.h
diff --git a/Source/core/css/CSSComputedStyleDeclaration.h b/Source/core/css/CSSComputedStyleDeclaration.h
index 201c04ad56df1081212502870a32d590adfd3f8a..683d47b1afc4af8514000e4fd4a535510e925590 100644
--- a/Source/core/css/CSSComputedStyleDeclaration.h
+++ b/Source/core/css/CSSComputedStyleDeclaration.h
@@ -62,8 +62,8 @@ public:
PassRefPtrWillBeRawPtr<MutableStylePropertySet> copyProperties() const;
- PassRefPtrWillBeRawPtr<CSSValue> getPropertyCSSValue(CSSPropertyID) const;
- PassRefPtrWillBeRawPtr<CSSValue> getFontSizeCSSValuePreferringKeyword() const;
+ NullableCSSValue getPropertyCSSValue(CSSPropertyID) const;
+ NullableCSSValue getFontSizeCSSValuePreferringKeyword() const;
bool isMonospaceFont() const;
PassRefPtrWillBeRawPtr<MutableStylePropertySet> copyPropertiesInSet(const Vector<CSSPropertyID>&) const;
@@ -93,11 +93,11 @@ private:
virtual String removeProperty(const String& propertyName, ExceptionState&) override;
virtual String cssText() const override;
virtual void setCSSText(const String&, ExceptionState&) override;
- virtual PassRefPtrWillBeRawPtr<CSSValue> getPropertyCSSValueInternal(CSSPropertyID) override;
+ virtual NullableCSSValue getPropertyCSSValueInternal(CSSPropertyID) override;
virtual String getPropertyValueInternal(CSSPropertyID) override;
virtual void setPropertyInternal(CSSPropertyID, const String& value, bool important, ExceptionState&) override;
- virtual bool cssPropertyMatches(CSSPropertyID, const CSSValue*) const override;
+ virtual bool cssPropertyMatches(CSSPropertyID, const CSSValue) const override;
RefPtrWillBeMember<Node> m_node;
PseudoId m_pseudoElementSpecifier;
« no previous file with comments | « Source/core/css/CSSCalculationValueTest.cpp ('k') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698