Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: Source/core/css/CSSBorderImage.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSBorderImage.h ('k') | Source/core/css/CSSBorderImageSliceValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSBorderImage.cpp
diff --git a/Source/core/css/CSSBorderImage.cpp b/Source/core/css/CSSBorderImage.cpp
index 4a569ed7b0048e593162167256bfbb3951ca9844..daecf653bdbb76f045e474efe126c1b247d29f2b 100644
--- a/Source/core/css/CSSBorderImage.cpp
+++ b/Source/core/css/CSSBorderImage.cpp
@@ -22,29 +22,30 @@
namespace blink {
-PassRefPtrWillBeRawPtr<CSSValueList> createBorderImageValue(PassRefPtrWillBeRawPtr<CSSValue> image, PassRefPtrWillBeRawPtr<CSSValue> imageSlice,
- PassRefPtrWillBeRawPtr<CSSValue> borderSlice, PassRefPtrWillBeRawPtr<CSSValue> outset, PassRefPtrWillBeRawPtr<CSSValue> repeat)
+PassRefPtrWillBeRawPtr<CSSValueList> createBorderImageValue(NullableCSSValue image, NullableCSSValue imageSlice,
+ NullableCSSValue borderSlice, NullableCSSValue outset, NullableCSSValue repeat)
{
RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
if (image)
- list->append(image);
+ list->append(*image);
if (borderSlice || outset) {
RefPtrWillBeRawPtr<CSSValueList> listSlash = CSSValueList::createSlashSeparated();
if (imageSlice)
- listSlash->append(imageSlice);
+ listSlash->append(*imageSlice);
if (borderSlice)
- listSlash->append(borderSlice);
+ listSlash->append(*borderSlice);
if (outset)
- listSlash->append(outset);
+ listSlash->append(*outset);
list->append(listSlash);
- } else if (imageSlice)
- list->append(imageSlice);
+ } else if (imageSlice) {
+ list->append(*imageSlice);
+ }
if (repeat)
- list->append(repeat);
+ list->append(*repeat);
return list.release();
}
« no previous file with comments | « Source/core/css/CSSBorderImage.h ('k') | Source/core/css/CSSBorderImageSliceValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698