Source/core/animation/animatable/AnimatableValueTestHelper.cpp - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/animatable/AnimatableValueTestHelper.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/animatable/AnimatableUnknownTest.cpp ('k') | Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/animatable/AnimatableValueTestHelper.cpp

diff --git a/Source/core/animation/animatable/AnimatableValueTestHelper.cpp b/Source/core/animation/animatable/AnimatableValueTestHelper.cpp

index add8e2419bfb44237f80ea862b7a19965f57b265..d79c3976073e150e08624a6a8c6262c6ce51d4dd 100644

--- a/Source/core/animation/animatable/AnimatableValueTestHelper.cpp

+++ b/Source/core/animation/animatable/AnimatableValueTestHelper.cpp

@@ -53,7 +53,7 @@ void PrintTo(const AnimatableColor& animColor, ::std::ostream* os)

void PrintTo(const AnimatableImage& animImage, ::std::ostream* os)

{

- PrintTo(*(animImage.toCSSValue()), os, "AnimatableImage");

+ PrintTo(animImage.toCSSValue(), os, "AnimatableImage");

}

void PrintTo(const AnimatableNeutral& animValue, ::std::ostream* os)

@@ -148,7 +148,7 @@ void PrintTo(const AnimatableTransform& animTransform, ::std::ostream* os)

void PrintTo(const AnimatableUnknown& animUnknown, ::std::ostream* os)

{

- PrintTo(*(animUnknown.toCSSValue().get()), os, "AnimatableUnknown");

+ PrintTo(animUnknown.toCSSValue(), os, "AnimatableUnknown");

}

void PrintTo(const AnimatableVisibility& animVisibility, ::std::ostream* os)