Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: Source/core/animation/animatable/AnimatableImage.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/animatable/AnimatableImage.h
diff --git a/Source/core/animation/animatable/AnimatableImage.h b/Source/core/animation/animatable/AnimatableImage.h
index 260f0b42cec57f52e8b66b0dcfd7d7537a176282..9914b8d378226936dd477dd24b130af20fb974d5 100644
--- a/Source/core/animation/animatable/AnimatableImage.h
+++ b/Source/core/animation/animatable/AnimatableImage.h
@@ -40,11 +40,11 @@ namespace blink {
class AnimatableImage final : public AnimatableValue {
public:
virtual ~AnimatableImage() { }
- static PassRefPtrWillBeRawPtr<AnimatableImage> create(PassRefPtrWillBeRawPtr<CSSValue> value)
+ static PassRefPtrWillBeRawPtr<AnimatableImage> create(CSSValue value)
{
return adoptRefWillBeNoop(new AnimatableImage(value));
}
- CSSValue* toCSSValue() const { return m_value.get(); }
+ CSSValue toCSSValue() const { return m_value; }
DEFINE_INLINE_VIRTUAL_TRACE()
{
@@ -57,15 +57,14 @@ protected:
virtual bool usesDefaultInterpolationWith(const AnimatableValue*) const override;
private:
- AnimatableImage(PassRefPtrWillBeRawPtr<CSSValue> value)
+ AnimatableImage(CSSValue value)
: m_value(value)
{
- ASSERT(m_value.get());
}
virtual AnimatableType type() const override { return TypeImage; }
virtual bool equalTo(const AnimatableValue*) const override;
- const RefPtrWillBeMember<CSSValue> m_value;
+ const CSSValue m_value;
};
DEFINE_ANIMATABLE_VALUE_TYPE_CASTS(AnimatableImage, isImage());
« no previous file with comments | « Source/core/animation/VisibilityStyleInterpolationTest.cpp ('k') | Source/core/animation/animatable/AnimatableImage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698