Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: Source/core/animation/LengthStyleInterpolation.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/LengthStyleInterpolation.cpp
diff --git a/Source/core/animation/LengthStyleInterpolation.cpp b/Source/core/animation/LengthStyleInterpolation.cpp
index 643581c3f97c149af72cefc85a9c71d3565e5e3b..bd52ac3755aa514408b1e2272ff98bdf15cc9c8a 100644
--- a/Source/core/animation/LengthStyleInterpolation.cpp
+++ b/Source/core/animation/LengthStyleInterpolation.cpp
@@ -51,7 +51,7 @@ bool pixelsForKeyword(CSSPropertyID property, CSSValueID valueID, double& result
} // namespace
-bool LengthStyleInterpolation::canCreateFrom(const CSSValue& value, CSSPropertyID property)
+bool LengthStyleInterpolation::canCreateFrom(const CSSValue value, CSSPropertyID property)
{
if (value.isPrimitiveValue()) {
const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
@@ -71,7 +71,7 @@ bool LengthStyleInterpolation::canCreateFrom(const CSSValue& value, CSSPropertyI
return value.isCalcValue();
}
-PassOwnPtrWillBeRawPtr<InterpolableValue> LengthStyleInterpolation::toInterpolableValue(const CSSValue& value, CSSPropertyID id)
+PassOwnPtrWillBeRawPtr<InterpolableValue> LengthStyleInterpolation::toInterpolableValue(const CSSValue value, CSSPropertyID id)
{
ASSERT(canCreateFrom(value, id));
OwnPtrWillBeRawPtr<InterpolableList> listOfValuesAndTypes = InterpolableList::create(2);
@@ -318,12 +318,12 @@ void LengthStyleInterpolation::apply(StyleResolverState& state) const
(state.style()->*m_lengthSetter)(lengthFromInterpolableValue(*m_cachedValue, m_range, state.style()->effectiveZoom()));
#if ENABLE(ASSERT)
RefPtrWillBeRawPtr<AnimatableValue> before = CSSAnimatableValueFactory::create(m_id, *state.style());
- StyleBuilder::applyProperty(m_id, state, fromInterpolableValue(*m_cachedValue, m_range).get());
+ StyleBuilder::applyProperty(m_id, state, fromInterpolableValue(*m_cachedValue, m_range));
RefPtrWillBeRawPtr<AnimatableValue> after = CSSAnimatableValueFactory::create(m_id, *state.style());
ASSERT(before->equals(*after));
#endif
} else {
- StyleBuilder::applyProperty(m_id, state, fromInterpolableValue(*m_cachedValue, m_range).get());
+ StyleBuilder::applyProperty(m_id, state, fromInterpolableValue(*m_cachedValue, m_range));
}
}
« no previous file with comments | « Source/core/animation/LengthStyleInterpolation.h ('k') | Source/core/animation/LengthStyleInterpolationTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698