Source/core/animation/DoubleStyleInterpolation.h - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/DoubleStyleInterpolation.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/DeferredLegacyStyleInterpolationTest.cpp ('k') | Source/core/animation/DoubleStyleInterpolation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/DoubleStyleInterpolation.h

diff --git a/Source/core/animation/DoubleStyleInterpolation.h b/Source/core/animation/DoubleStyleInterpolation.h

index 688513c68115f03a42f8a479d8bb6eb28446ae87..05b81ed6e37aa1c712963198963000550b640dea 100644

--- a/Source/core/animation/DoubleStyleInterpolation.h

+++ b/Source/core/animation/DoubleStyleInterpolation.h

@@ -29,7 +29,7 @@ public:

DECLARE_VIRTUAL_TRACE();

static PassOwnPtrWillBeRawPtr<InterpolableValue> toInterpolableValue(const CSSValue&, CSSPropertyID = CSSPropertyInvalid);

- static PassRefPtrWillBeRawPtr<CSSValue> fromInterpolableValue(const InterpolableValue&, InterpolationRange);

+ static CSSValue fromInterpolableValue(const InterpolableValue&, InterpolationRange);

private:

DoubleStyleInterpolation(PassOwnPtrWillBeRawPtr<InterpolableValue> start, PassOwnPtrWillBeRawPtr<InterpolableValue> end, CSSPropertyID id, bool isNumber, InterpolationRange clamp, bool flag)

@@ -42,8 +42,8 @@ private:

static PassOwnPtrWillBeRawPtr<InterpolableValue> doubleToInterpolableValue(const CSSValue&);

static PassOwnPtrWillBeRawPtr<InterpolableValue> motionRotationToInterpolableValue(const CSSValue&);

- static PassRefPtrWillBeRawPtr<CSSValue> interpolableValueToDouble(const InterpolableValue*, bool, InterpolationRange);

- static PassRefPtrWillBeRawPtr<CSSValue> interpolableValueToMotionRotation(InterpolableValue*, bool);

+ static CSSValue interpolableValueToDouble(const InterpolableValue*, bool, InterpolationRange);

+ static CSSValue interpolableValueToMotionRotation(InterpolableValue*, bool);

bool m_isNumber;

InterpolationRange m_clamp;