Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: Source/core/animation/DeferredLegacyStyleInterpolation.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/DeferredLegacyStyleInterpolation.cpp
diff --git a/Source/core/animation/DeferredLegacyStyleInterpolation.cpp b/Source/core/animation/DeferredLegacyStyleInterpolation.cpp
index d70f13b8a3d06492c1a2b4e7dc443445d1fa9211..6c1ebfd56fbd0a04bb5af9f8cdbee3b5d33c5f03 100644
--- a/Source/core/animation/DeferredLegacyStyleInterpolation.cpp
+++ b/Source/core/animation/DeferredLegacyStyleInterpolation.cpp
@@ -28,11 +28,11 @@ void DeferredLegacyStyleInterpolation::apply(StyleResolverState& state) const
// Snapshot underlying values for neutral keyframes first because non-neutral keyframes will mutate the StyleResolverState.
if (!m_endCSSValue) {
- endAnimatableValue = StyleResolver::createAnimatableValueSnapshot(state, m_id, m_endCSSValue.get());
- startAnimatableValue = StyleResolver::createAnimatableValueSnapshot(state, m_id, m_startCSSValue.get());
+ endAnimatableValue = StyleResolver::createAnimatableValueSnapshot(state, m_id, m_endCSSValue);
+ startAnimatableValue = StyleResolver::createAnimatableValueSnapshot(state, m_id, m_startCSSValue);
} else {
- startAnimatableValue = StyleResolver::createAnimatableValueSnapshot(state, m_id, m_startCSSValue.get());
- endAnimatableValue = StyleResolver::createAnimatableValueSnapshot(state, m_id, m_endCSSValue.get());
+ startAnimatableValue = StyleResolver::createAnimatableValueSnapshot(state, m_id, m_startCSSValue);
+ endAnimatableValue = StyleResolver::createAnimatableValueSnapshot(state, m_id, m_endCSSValue);
}
m_innerInterpolation = LegacyStyleInterpolation::create(startAnimatableValue, endAnimatableValue, m_id);
@@ -137,7 +137,7 @@ bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C
{
size_t length = valueList.length();
for (size_t index = 0; index < length; ++index) {
- if (interpolationRequiresStyleResolve(*valueList.item(index)))
+ if (interpolationRequiresStyleResolve(valueList.item(index)))
return true;
}
return false;

Powered by Google App Engine
This is Rietveld 408576698