Source/core/css/parser/SizesCalcParserTest.cpp - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/SizesCalcParserTest.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/parser/CSSParserImpl.cpp ('K') | « Source/core/css/parser/CSSPropertyParserTest.cpp ('k') | Source/core/css/resolver/AnimatedStyleBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/SizesCalcParserTest.cpp

diff --git a/Source/core/css/parser/SizesCalcParserTest.cpp b/Source/core/css/parser/SizesCalcParserTest.cpp

index 8fcd90c3831bf3428a2614d03ca48db1636ef6c0..b1edc32076b1e26d8347bff71bffd663ecfd34e1 100644

--- a/Source/core/css/parser/SizesCalcParserTest.cpp

+++ b/Source/core/css/parser/SizesCalcParserTest.cpp

@@ -33,8 +33,8 @@ static void verifyCSSCalc(String text, double value, bool valid, unsigned fontSi

{

CSSLengthArray lengthArray;

initLengthArray(lengthArray);

- RefPtrWillBeRawPtr<CSSValue> cssValue = CSSParser::parseSingleValue(CSSPropertyLeft, text);

- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(cssValue.get());

+ NullableCSSValue cssValue = CSSParser::parseSingleValue(CSSPropertyLeft, text);

+ CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(cssValue);

if (primitiveValue)

primitiveValue->accumulateLengthArray(lengthArray);

else