Source/core/css/parser/CSSParser.h - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParser.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/parser/CSSParser.h

diff --git a/Source/core/css/parser/CSSParser.h b/Source/core/css/parser/CSSParser.h

index 5b94c4b567e0043a9178691f40839a8e110149c0..140d72b836ddc2e77670e64d3dbedacf0a0b453b 100644

--- a/Source/core/css/parser/CSSParser.h

+++ b/Source/core/css/parser/CSSParser.h

@@ -38,9 +38,9 @@ public:

static bool parseValue(MutableStylePropertySet*, CSSPropertyID unresolvedProperty, const String&, bool important, CSSParserMode, StyleSheetContents*);

// This is for non-shorthands only

- static PassRefPtrWillBeRawPtr<CSSValue> parseSingleValue(CSSPropertyID, const String&, const CSSParserContext& = strictCSSParserContext());

+ static NullableCSSValue parseSingleValue(CSSPropertyID, const String&, const CSSParserContext& = strictCSSParserContext());

- static PassRefPtrWillBeRawPtr<CSSValue> parseFontFaceDescriptor(CSSPropertyID, const String&, const CSSParserContext&);

+ static NullableCSSValue parseFontFaceDescriptor(CSSPropertyID, const String&, const CSSParserContext&);

static PassRefPtrWillBeRawPtr<ImmutableStylePropertySet> parseInlineStyleDeclaration(const String&, Element*);

« Source/core/css/CSSValue.h ('K') | « Source/core/css/StylePropertySet.cpp ('k') | Source/core/css/parser/CSSParser.cpp » ('j') | Source/core/css/parser/CSSParserImpl.cpp » ('J')