Source/core/css/PropertySetCSSStyleDeclaration.h - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/PropertySetCSSStyleDeclaration.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/PropertySetCSSStyleDeclaration.h

diff --git a/Source/core/css/PropertySetCSSStyleDeclaration.h b/Source/core/css/PropertySetCSSStyleDeclaration.h

index 291e787ca6a3f9507fa56e9baca893818ddb173c..373cbe5f76e3312286eb93bb9135e7eaf1997753 100644

--- a/Source/core/css/PropertySetCSSStyleDeclaration.h

+++ b/Source/core/css/PropertySetCSSStyleDeclaration.h

@@ -58,11 +58,11 @@ private:

virtual String removeProperty(const String& propertyName, ExceptionState&) override final;

virtual String cssText() const override final;

virtual void setCSSText(const String&, ExceptionState&) override final;

- virtual PassRefPtrWillBeRawPtr<CSSValue> getPropertyCSSValueInternal(CSSPropertyID) override final;

+ virtual NullableCSSValue getPropertyCSSValueInternal(CSSPropertyID) override final;

virtual String getPropertyValueInternal(CSSPropertyID) override final;

virtual void setPropertyInternal(CSSPropertyID, const String& value, bool important, ExceptionState&) override final;

- virtual bool cssPropertyMatches(CSSPropertyID, const CSSValue*) const override final;

+ virtual bool cssPropertyMatches(CSSPropertyID, const CSSValue) const override final;

virtual PassRefPtrWillBeRawPtr<MutableStylePropertySet> copyProperties() const override final;

protected:

« Source/core/css/CSSValue.h ('K') | « Source/core/css/FontFace.cpp ('k') | Source/core/css/PropertySetCSSStyleDeclaration.cpp » ('j') | Source/core/css/parser/CSSParserImpl.cpp » ('J')