Source/core/animation/css/CSSAnimatableValueFactory.cpp - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase and oilpan feedback Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp ('k') | Source/core/animation/css/CSSAnimations.cpp » ('j') | Source/core/css/CSSValue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/css/CSSAnimatableValueFactory.cpp

diff --git a/Source/core/animation/css/CSSAnimatableValueFactory.cpp b/Source/core/animation/css/CSSAnimatableValueFactory.cpp

index abd9d8c51ef5f975efe67f65915e64d31ba6b226..4a2b4a244c13df76b2588e31ab68819b6e156129 100644

--- a/Source/core/animation/css/CSSAnimatableValueFactory.cpp

+++ b/Source/core/animation/css/CSSAnimatableValueFactory.cpp

@@ -178,8 +178,8 @@ inline static PassRefPtrWillBeRawPtr<AnimatableValue> createFromLengthSize(const

inline static PassRefPtrWillBeRawPtr<AnimatableValue> createFromStyleImage(StyleImage* image)

{

if (image) {

- if (RefPtrWillBeRawPtr<CSSValue> cssValue = image->cssValue())

- return AnimatableImage::create(cssValue.release());

+ if (NullableCSSValue cssValue = image->cssValue())

+ return AnimatableImage::create(*cssValue);

}

return AnimatableUnknown::create(CSSValueNone);

}