Source/core/css/CSSUnicodeRangeValue.h - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSUnicodeRangeValue.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: More oilpan fixes & oilpan review feedback ; still failing tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSUnicodeRangeValue.h

diff --git a/Source/core/css/CSSUnicodeRangeValue.h b/Source/core/css/CSSUnicodeRangeValue.h

index eabe25fdffc9dd8bee8443660800156fd5df61d6..30c19a031ac927f692d045e4408bec5e15952856 100644

--- a/Source/core/css/CSSUnicodeRangeValue.h

+++ b/Source/core/css/CSSUnicodeRangeValue.h

@@ -31,7 +31,7 @@

namespace blink {

-class CSSUnicodeRangeValue : public CSSValue {

+class CSSUnicodeRangeValue : public CSSValueObject {

public:

static PassRefPtrWillBeRawPtr<CSSUnicodeRangeValue> create(UChar32 from, UChar32 to)

{

@@ -45,11 +45,11 @@ public:

bool equals(const CSSUnicodeRangeValue&) const;

- DEFINE_INLINE_TRACE_AFTER_DISPATCH() { CSSValue::traceAfterDispatch(visitor); }

+ DEFINE_INLINE_TRACE_AFTER_DISPATCH() { CSSValueObject::traceAfterDispatch(visitor); }

private:

CSSUnicodeRangeValue(UChar32 from, UChar32 to)

- : CSSValue(UnicodeRangeClass)

+ : CSSValueObject(UnicodeRangeClass)

, m_from(from)

, m_to(to)

{

« no previous file with comments | « Source/core/css/CSSTimingFunctionValue.h ('k') | Source/core/css/CSSUnsetValue.h » ('j') | Source/core/css/CSSValue.h » ('J')