Source/core/css/CSSShadowValue.cpp - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSShadowValue.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: More oilpan fixes & oilpan review feedback ; still failing tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSShadowValue.cpp

diff --git a/Source/core/css/CSSShadowValue.cpp b/Source/core/css/CSSShadowValue.cpp

index 38663d3fa65051c795b9f751cc6c66386a81b92c..260250441f4c3ee057843cce4bb1e9ce25e05d00 100644

--- a/Source/core/css/CSSShadowValue.cpp

+++ b/Source/core/css/CSSShadowValue.cpp

@@ -33,7 +33,7 @@ CSSShadowValue::CSSShadowValue(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> x,

PassRefPtrWillBeRawPtr<CSSPrimitiveValue> spread,

PassRefPtrWillBeRawPtr<CSSPrimitiveValue> style,

PassRefPtrWillBeRawPtr<CSSPrimitiveValue> color)

- : CSSValue(ShadowClass)

+ : CSSValueObject(ShadowClass)

, x(x)

, y(y)

, blur(blur)

@@ -96,7 +96,7 @@ DEFINE_TRACE_AFTER_DISPATCH(CSSShadowValue)

visitor->trace(spread);

visitor->trace(style);

visitor->trace(color);

- CSSValue::traceAfterDispatch(visitor);

+ CSSValueObject::traceAfterDispatch(visitor);

}

« no previous file with comments | « Source/core/css/CSSShadowValue.h ('k') | Source/core/css/CSSStyleDeclaration.h » ('j') | Source/core/css/CSSValue.h » ('J')