Source/core/animation/LengthStyleInterpolation.h - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/LengthStyleInterpolation.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: (Hopefully) Builds with oilpan now Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/LengthPairStyleInterpolationTest.cpp ('k') | Source/core/animation/LengthStyleInterpolation.cpp » ('j') | Source/core/animation/animatable/AnimatableUnknownTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/LengthStyleInterpolation.h

diff --git a/Source/core/animation/LengthStyleInterpolation.h b/Source/core/animation/LengthStyleInterpolation.h

index fd7302e587cf12f2963435754b6bfc010dff968d..e7d04eb496ba259203a4b0c98d9f8684a17a18b0 100644

--- a/Source/core/animation/LengthStyleInterpolation.h

+++ b/Source/core/animation/LengthStyleInterpolation.h

@@ -24,13 +24,13 @@ public:

return adoptRefWillBeNoop(new LengthStyleInterpolation(toInterpolableValue(start, id), toInterpolableValue(end, id), id, range));

}

- static bool canCreateFrom(const CSSValue&, CSSPropertyID = CSSPropertyInvalid);

+ static bool canCreateFrom(const CSSValue, CSSPropertyID = CSSPropertyInvalid);

virtual void apply(StyleResolverState&) const override;

DECLARE_VIRTUAL_TRACE();

- static PassOwnPtrWillBeRawPtr<InterpolableValue> toInterpolableValue(const CSSValue&, CSSPropertyID = CSSPropertyInvalid);

+ static PassOwnPtrWillBeRawPtr<InterpolableValue> toInterpolableValue(CSSValue, CSSPropertyID = CSSPropertyInvalid);

static PassRefPtrWillBeRawPtr<CSSPrimitiveValue> fromInterpolableValue(const InterpolableValue&, InterpolationRange);

private: