Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/css/resolver/CSSToStyleMap.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/css/CSSValue.h ('K') | « Source/core/css/resolver/CSSToStyleMap.h ('k') | Source/core/css/resolver/ElementStyleResources.h » ('j') | Source/core/css/resolver/ElementStyleResources.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/resolver/CSSToStyleMap.cpp
diff --git a/Source/core/css/resolver/CSSToStyleMap.cpp b/Source/core/css/resolver/CSSToStyleMap.cpp
index ac5558604534413ef3d1a4b4ba0b460a9ffeb338..269bd050f35e6f093f1e3d004b65aa76dc016824 100644
--- a/Source/core/css/resolver/CSSToStyleMap.cpp
+++ b/Source/core/css/resolver/CSSToStyleMap.cpp
@@ -43,18 +43,18 @@
namespace blink {
-void CSSToStyleMap::mapFillAttachment(StyleResolverState&, FillLayer* layer, CSSValue* value)
+void CSSToStyleMap::mapFillAttachment(StyleResolverState&, FillLayer* layer, CSSValue value)
{
- if (value->isInitialValue()) {
+ if (value.isInitialValue()) {
layer->setAttachment(FillLayer::initialFillAttachment(layer->type()));
return;
}
- if (!value->isPrimitiveValue())
+ if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- switch (primitiveValue->getValueID()) {
+ CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ switch (primitiveValue.getValueID()) {
case CSSValueFixed:
layer->setAttachment(FixedBackgroundAttachment);
break;
@@ -69,66 +69,66 @@ void CSSToStyleMap::mapFillAttachment(StyleResolverState&, FillLayer* layer, CSS
}
}
-void CSSToStyleMap::mapFillClip(StyleResolverState&, FillLayer* layer, CSSValue* value)
+void CSSToStyleMap::mapFillClip(StyleResolverState&, FillLayer* layer, CSSValue value)
{
- if (value->isInitialValue()) {
+ if (value.isInitialValue()) {
layer->setClip(FillLayer::initialFillClip(layer->type()));
return;
}
- if (!value->isPrimitiveValue())
+ if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- layer->setClip(*primitiveValue);
+ CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ layer->setClip(primitiveValue);
}
-void CSSToStyleMap::mapFillComposite(StyleResolverState&, FillLayer* layer, CSSValue* value)
+void CSSToStyleMap::mapFillComposite(StyleResolverState&, FillLayer* layer, CSSValue value)
{
- if (value->isInitialValue()) {
+ if (value.isInitialValue()) {
layer->setComposite(FillLayer::initialFillComposite(layer->type()));
return;
}
- if (!value->isPrimitiveValue())
+ if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- layer->setComposite(*primitiveValue);
+ CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ layer->setComposite(primitiveValue);
}
-void CSSToStyleMap::mapFillBlendMode(StyleResolverState&, FillLayer* layer, CSSValue* value)
+void CSSToStyleMap::mapFillBlendMode(StyleResolverState&, FillLayer* layer, CSSValue value)
{
- if (value->isInitialValue()) {
+ if (value.isInitialValue()) {
layer->setBlendMode(FillLayer::initialFillBlendMode(layer->type()));
return;
}
- if (!value->isPrimitiveValue())
+ if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- layer->setBlendMode(*primitiveValue);
+ CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ layer->setBlendMode(primitiveValue);
}
-void CSSToStyleMap::mapFillOrigin(StyleResolverState&, FillLayer* layer, CSSValue* value)
+void CSSToStyleMap::mapFillOrigin(StyleResolverState&, FillLayer* layer, CSSValue value)
{
- if (value->isInitialValue()) {
+ if (value.isInitialValue()) {
layer->setOrigin(FillLayer::initialFillOrigin(layer->type()));
return;
}
- if (!value->isPrimitiveValue())
+ if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- layer->setOrigin(*primitiveValue);
+ CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ layer->setOrigin(primitiveValue);
}
-void CSSToStyleMap::mapFillImage(StyleResolverState& state, FillLayer* layer, CSSValue* value)
+void CSSToStyleMap::mapFillImage(StyleResolverState& state, FillLayer* layer, CSSValue value)
{
- if (value->isInitialValue()) {
+ if (value.isInitialValue()) {
layer->setImage(FillLayer::initialFillImage(layer->type()));
return;
}
@@ -137,56 +137,56 @@ void CSSToStyleMap::mapFillImage(StyleResolverState& state, FillLayer* layer, CS
layer->setImage(state.styleImage(property, value));
}
-void CSSToStyleMap::mapFillRepeatX(StyleResolverState&, FillLayer* layer, CSSValue* value)
+void CSSToStyleMap::mapFillRepeatX(StyleResolverState&, FillLayer* layer, CSSValue value)
{
- if (value->isInitialValue()) {
+ if (value.isInitialValue()) {
layer->setRepeatX(FillLayer::initialFillRepeatX(layer->type()));
return;
}
- if (!value->isPrimitiveValue())
+ if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- layer->setRepeatX(*primitiveValue);
+ CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ layer->setRepeatX(primitiveValue);
}
-void CSSToStyleMap::mapFillRepeatY(StyleResolverState&, FillLayer* layer, CSSValue* value)
+void CSSToStyleMap::mapFillRepeatY(StyleResolverState&, FillLayer* layer, CSSValue value)
{
- if (value->isInitialValue()) {
+ if (value.isInitialValue()) {
layer->setRepeatY(FillLayer::initialFillRepeatY(layer->type()));
return;
}
- if (!value->isPrimitiveValue())
+ if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- layer->setRepeatY(*primitiveValue);
+ CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ layer->setRepeatY(primitiveValue);
}
-void CSSToStyleMap::mapFillSize(StyleResolverState& state, FillLayer* layer, CSSValue* value)
+void CSSToStyleMap::mapFillSize(StyleResolverState& state, FillLayer* layer, CSSValue value)
{
- if (value->isInitialValue()) {
+ if (value.isInitialValue()) {
layer->setSizeType(FillLayer::initialFillSizeType(layer->type()));
layer->setSizeLength(FillLayer::initialFillSizeLength(layer->type()));
return;
}
- if (!value->isPrimitiveValue())
+ if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- if (primitiveValue->getValueID() == CSSValueContain)
+ CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ if (primitiveValue.getValueID() == CSSValueContain)
layer->setSizeType(Contain);
- else if (primitiveValue->getValueID() == CSSValueCover)
+ else if (primitiveValue.getValueID() == CSSValueCover)
layer->setSizeType(Cover);
else
layer->setSizeType(SizeLength);
LengthSize b = FillLayer::initialFillSizeLength(layer->type());
- if (primitiveValue->getValueID() == CSSValueContain || primitiveValue->getValueID() == CSSValueCover) {
+ if (primitiveValue.getValueID() == CSSValueContain || primitiveValue.getValueID() == CSSValueCover) {
layer->setSizeLength(b);
return;
}
@@ -194,11 +194,11 @@ void CSSToStyleMap::mapFillSize(StyleResolverState& state, FillLayer* layer, CSS
Length firstLength;
Length secondLength;
- if (Pair* pair = primitiveValue->getPairValue()) {
+ if (Pair* pair = primitiveValue.getPairValue()) {
firstLength = StyleBuilderConverter::convertLengthOrAuto(state, pair->first());
secondLength = StyleBuilderConverter::convertLengthOrAuto(state, pair->second());
} else {
- firstLength = StyleBuilderConverter::convertLengthOrAuto(state, primitiveValue);
+ firstLength = StyleBuilderConverter::convertLengthOrAuto(state, value);
secondLength = Length();
}
@@ -207,17 +207,17 @@ void CSSToStyleMap::mapFillSize(StyleResolverState& state, FillLayer* layer, CSS
layer->setSizeLength(b);
}
-void CSSToStyleMap::mapFillXPosition(StyleResolverState& state, FillLayer* layer, CSSValue* value)
+void CSSToStyleMap::mapFillXPosition(StyleResolverState& state, FillLayer* layer, CSSValue value)
{
- if (value->isInitialValue()) {
+ if (value.isInitialValue()) {
layer->setXPosition(FillLayer::initialFillXPosition(layer->type()));
return;
}
- if (!value->isPrimitiveValue())
+ if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
+ CSSPrimitiveValue* primitiveValue = &toCSSPrimitiveValue(value);
Pair* pair = primitiveValue->getPairValue();
if (pair)
primitiveValue = pair->second();
@@ -229,17 +229,17 @@ void CSSToStyleMap::mapFillXPosition(StyleResolverState& state, FillLayer* layer
layer->setBackgroundXOrigin(*(pair->first()));
}
-void CSSToStyleMap::mapFillYPosition(StyleResolverState& state, FillLayer* layer, CSSValue* value)
+void CSSToStyleMap::mapFillYPosition(StyleResolverState& state, FillLayer* layer, CSSValue value)
{
- if (value->isInitialValue()) {
+ if (value.isInitialValue()) {
layer->setYPosition(FillLayer::initialFillYPosition(layer->type()));
return;
}
- if (!value->isPrimitiveValue())
+ if (!value.isPrimitiveValue())
return;
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
+ CSSPrimitiveValue* primitiveValue = &toCSSPrimitiveValue(value);
Pair* pair = primitiveValue->getPairValue();
if (pair)
primitiveValue = pair->second();
@@ -251,18 +251,18 @@ void CSSToStyleMap::mapFillYPosition(StyleResolverState& state, FillLayer* layer
layer->setBackgroundYOrigin(*(pair->first()));
}
-void CSSToStyleMap::mapFillMaskSourceType(StyleResolverState&, FillLayer* layer, CSSValue* value)
+void CSSToStyleMap::mapFillMaskSourceType(StyleResolverState&, FillLayer* layer, CSSValue value)
{
EMaskSourceType type = FillLayer::initialFillMaskSourceType(layer->type());
- if (value->isInitialValue()) {
+ if (value.isInitialValue()) {
layer->setMaskSourceType(type);
return;
}
- if (!value->isPrimitiveValue())
+ if (!value.isPrimitiveValue())
return;
- switch (toCSSPrimitiveValue(value)->getValueID()) {
+ switch (toCSSPrimitiveValue(value).getValueID()) {
case CSSValueAlpha:
type = MaskAlpha;
break;
@@ -278,19 +278,19 @@ void CSSToStyleMap::mapFillMaskSourceType(StyleResolverState&, FillLayer* layer,
layer->setMaskSourceType(type);
}
-double CSSToStyleMap::mapAnimationDelay(CSSValue* value)
+double CSSToStyleMap::mapAnimationDelay(CSSValue value)
{
- if (value->isInitialValue())
+ if (value.isInitialValue())
return CSSTimingData::initialDelay();
- return toCSSPrimitiveValue(value)->computeSeconds();
+ return toCSSPrimitiveValue(value).computeSeconds();
}
-Timing::PlaybackDirection CSSToStyleMap::mapAnimationDirection(CSSValue* value)
+Timing::PlaybackDirection CSSToStyleMap::mapAnimationDirection(CSSValue value)
{
- if (value->isInitialValue())
+ if (value.isInitialValue())
return CSSAnimationData::initialDirection();
- switch (toCSSPrimitiveValue(value)->getValueID()) {
+ switch (toCSSPrimitiveValue(value).getValueID()) {
case CSSValueNormal:
return Timing::PlaybackDirectionNormal;
case CSSValueAlternate:
@@ -305,19 +305,19 @@ Timing::PlaybackDirection CSSToStyleMap::mapAnimationDirection(CSSValue* value)
}
}
-double CSSToStyleMap::mapAnimationDuration(CSSValue* value)
+double CSSToStyleMap::mapAnimationDuration(CSSValue value)
{
- if (value->isInitialValue())
+ if (value.isInitialValue())
return CSSTimingData::initialDuration();
- return toCSSPrimitiveValue(value)->computeSeconds();
+ return toCSSPrimitiveValue(value).computeSeconds();
}
-Timing::FillMode CSSToStyleMap::mapAnimationFillMode(CSSValue* value)
+Timing::FillMode CSSToStyleMap::mapAnimationFillMode(CSSValue value)
{
- if (value->isInitialValue())
+ if (value.isInitialValue())
return CSSAnimationData::initialFillMode();
- switch (toCSSPrimitiveValue(value)->getValueID()) {
+ switch (toCSSPrimitiveValue(value).getValueID()) {
case CSSValueNone:
return Timing::FillModeNone;
case CSSValueForwards:
@@ -332,60 +332,60 @@ Timing::FillMode CSSToStyleMap::mapAnimationFillMode(CSSValue* value)
}
}
-double CSSToStyleMap::mapAnimationIterationCount(CSSValue* value)
+double CSSToStyleMap::mapAnimationIterationCount(CSSValue value)
{
- if (value->isInitialValue())
+ if (value.isInitialValue())
return CSSAnimationData::initialIterationCount();
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- if (primitiveValue->getValueID() == CSSValueInfinite)
+ CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ if (primitiveValue.getValueID() == CSSValueInfinite)
return std::numeric_limits<double>::infinity();
- return primitiveValue->getFloatValue();
+ return primitiveValue.getFloatValue();
}
-AtomicString CSSToStyleMap::mapAnimationName(CSSValue* value)
+AtomicString CSSToStyleMap::mapAnimationName(CSSValue value)
{
- if (value->isInitialValue())
+ if (value.isInitialValue())
return CSSAnimationData::initialName();
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- if (primitiveValue->getValueID() == CSSValueNone)
+ CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ if (primitiveValue.getValueID() == CSSValueNone)
return CSSAnimationData::initialName();
- return AtomicString(primitiveValue->getStringValue());
+ return AtomicString(primitiveValue.getStringValue());
}
-EAnimPlayState CSSToStyleMap::mapAnimationPlayState(CSSValue* value)
+EAnimPlayState CSSToStyleMap::mapAnimationPlayState(CSSValue value)
{
- if (value->isInitialValue())
+ if (value.isInitialValue())
return CSSAnimationData::initialPlayState();
- if (toCSSPrimitiveValue(value)->getValueID() == CSSValuePaused)
+ if (toCSSPrimitiveValue(value).getValueID() == CSSValuePaused)
return AnimPlayStatePaused;
- ASSERT(toCSSPrimitiveValue(value)->getValueID() == CSSValueRunning);
+ ASSERT(toCSSPrimitiveValue(value).getValueID() == CSSValueRunning);
return AnimPlayStatePlaying;
}
-CSSTransitionData::TransitionProperty CSSToStyleMap::mapAnimationProperty(CSSValue* value)
+CSSTransitionData::TransitionProperty CSSToStyleMap::mapAnimationProperty(CSSValue value)
{
- if (value->isInitialValue())
+ if (value.isInitialValue())
return CSSTransitionData::initialProperty();
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- if (primitiveValue->isString())
- return CSSTransitionData::TransitionProperty(primitiveValue->getStringValue());
- if (primitiveValue->getValueID() == CSSValueAll)
+ CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ if (primitiveValue.isString())
+ return CSSTransitionData::TransitionProperty(primitiveValue.getStringValue());
+ if (primitiveValue.getValueID() == CSSValueAll)
return CSSTransitionData::TransitionProperty(CSSTransitionData::TransitionAll);
- if (primitiveValue->getValueID() == CSSValueNone)
+ if (primitiveValue.getValueID() == CSSValueNone)
return CSSTransitionData::TransitionProperty(CSSTransitionData::TransitionNone);
- return CSSTransitionData::TransitionProperty(primitiveValue->getPropertyID());
+ return CSSTransitionData::TransitionProperty(primitiveValue.getPropertyID());
}
-PassRefPtr<TimingFunction> CSSToStyleMap::mapAnimationTimingFunction(CSSValue* value, bool allowStepMiddle)
+PassRefPtr<TimingFunction> CSSToStyleMap::mapAnimationTimingFunction(CSSValue value, bool allowStepMiddle)
{
// FIXME: We should probably only call into this function with a valid
// single timing function value which isn't initial or inherit. We can
// currently get into here with initial since the parser expands unset
// properties in shorthands to initial.
- if (value->isPrimitiveValue()) {
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- switch (primitiveValue->getValueID()) {
+ if (value.isPrimitiveValue()) {
+ CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
+ switch (primitiveValue.getValueID()) {
case CSSValueLinear:
return LinearTimingFunction::shared();
case CSSValueEase:
@@ -410,21 +410,21 @@ PassRefPtr<TimingFunction> CSSToStyleMap::mapAnimationTimingFunction(CSSValue* v
}
}
- if (value->isCubicBezierTimingFunctionValue()) {
- CSSCubicBezierTimingFunctionValue* cubicTimingFunction = toCSSCubicBezierTimingFunctionValue(value);
- return CubicBezierTimingFunction::create(cubicTimingFunction->x1(), cubicTimingFunction->y1(), cubicTimingFunction->x2(), cubicTimingFunction->y2());
+ if (value.isCubicBezierTimingFunctionValue()) {
+ CSSCubicBezierTimingFunctionValue& cubicTimingFunction = toCSSCubicBezierTimingFunctionValue(value);
+ return CubicBezierTimingFunction::create(cubicTimingFunction.x1(), cubicTimingFunction.y1(), cubicTimingFunction.x2(), cubicTimingFunction.y2());
}
- if (value->isInitialValue())
+ if (value.isInitialValue())
return CSSTimingData::initialTimingFunction();
- CSSStepsTimingFunctionValue* stepsTimingFunction = toCSSStepsTimingFunctionValue(value);
- if (stepsTimingFunction->stepAtPosition() == StepsTimingFunction::Middle && !allowStepMiddle)
+ CSSStepsTimingFunctionValue& stepsTimingFunction = toCSSStepsTimingFunctionValue(value);
+ if (stepsTimingFunction.stepAtPosition() == StepsTimingFunction::Middle && !allowStepMiddle)
return CSSTimingData::initialTimingFunction();
- return StepsTimingFunction::create(stepsTimingFunction->numberOfSteps(), stepsTimingFunction->stepAtPosition());
+ return StepsTimingFunction::create(stepsTimingFunction.numberOfSteps(), stepsTimingFunction.stepAtPosition());
}
-void CSSToStyleMap::mapNinePieceImage(StyleResolverState& state, CSSPropertyID property, CSSValue* value, NinePieceImage& image)
+void CSSToStyleMap::mapNinePieceImage(StyleResolverState& state, CSSPropertyID property, NullableCSSValue value, NinePieceImage& image)
{
// If we're not a value list, then we are "none" and don't need to alter the empty image at all.
if (!value || !value->isValueList())
@@ -443,27 +443,27 @@ void CSSToStyleMap::mapNinePieceImage(StyleResolverState& state, CSSPropertyID p
imageProperty = property;
for (unsigned i = 0 ; i < borderImage->length() ; ++i) {
- CSSValue* current = borderImage->item(i);
+ CSSValue current = borderImage->item(i);
- if (current->isImageValue() || current->isImageGeneratorValue() || current->isImageSetValue())
+ if (current.isImageValue() || current.isImageGeneratorValue() || current.isImageSetValue()) {
image.setImage(state.styleImage(imageProperty, current));
- else if (current->isBorderImageSliceValue())
+ } else if (current.isBorderImageSliceValue()) {
mapNinePieceImageSlice(state, current, image);
- else if (current->isValueList()) {
- CSSValueList* slashList = toCSSValueList(current);
- size_t length = slashList->length();
+ } else if (current.isValueList()) {
+ CSSValueList& slashList = toCSSValueList(current);
+ size_t length = slashList.length();
// Map in the image slices.
- if (length && slashList->item(0)->isBorderImageSliceValue())
- mapNinePieceImageSlice(state, slashList->item(0), image);
+ if (length && slashList.item(0).isBorderImageSliceValue())
+ mapNinePieceImageSlice(state, slashList.item(0), image);
// Map in the border slices.
if (length > 1)
- image.setBorderSlices(mapNinePieceImageQuad(state, slashList->item(1)));
+ image.setBorderSlices(mapNinePieceImageQuad(state, slashList.item(1)));
// Map in the outset.
if (length > 2)
- image.setOutset(mapNinePieceImageQuad(state, slashList->item(2)));
- } else if (current->isPrimitiveValue()) {
+ image.setOutset(mapNinePieceImageQuad(state, slashList.item(2)));
+ } else if (current.isPrimitiveValue()) {
// Set the appropriate rules for stretch/round/repeat of the slices.
mapNinePieceImageRepeat(state, current, image);
}
@@ -484,7 +484,7 @@ void CSSToStyleMap::mapNinePieceImage(StyleResolverState& state, CSSPropertyID p
}
}
-void CSSToStyleMap::mapNinePieceImageSlice(StyleResolverState&, CSSValue* value, NinePieceImage& image)
+void CSSToStyleMap::mapNinePieceImageSlice(StyleResolverState&, NullableCSSValue value, NinePieceImage& image)
Timothy Loh 2015/06/02 00:42:03 not nullable?
{
if (!value || !value->isBorderImageSliceValue())
return;
@@ -528,7 +528,7 @@ static BorderImageLength toBorderImageLength(CSSPrimitiveValue& value, const CSS
return Length(Auto);
}
-BorderImageLengthBox CSSToStyleMap::mapNinePieceImageQuad(StyleResolverState& state, CSSValue* value)
+BorderImageLengthBox CSSToStyleMap::mapNinePieceImageQuad(StyleResolverState& state, NullableCSSValue value)
Timothy Loh 2015/06/02 00:42:03 not nullable?
{
if (!value || !value->isPrimitiveValue())
return BorderImageLengthBox(Length(Auto));
@@ -543,7 +543,7 @@ BorderImageLengthBox CSSToStyleMap::mapNinePieceImageQuad(StyleResolverState& st
toBorderImageLength(*slices->left(), state.cssToLengthConversionData()));
}
-void CSSToStyleMap::mapNinePieceImageRepeat(StyleResolverState&, CSSValue* value, NinePieceImage& image)
+void CSSToStyleMap::mapNinePieceImageRepeat(StyleResolverState&, NullableCSSValue value, NinePieceImage& image)
Timothy Loh 2015/06/02 00:42:03 not nullable?
{
if (!value || !value->isPrimitiveValue())
return;
« Source/core/css/CSSValue.h ('K') | « Source/core/css/resolver/CSSToStyleMap.h ('k') | Source/core/css/resolver/ElementStyleResources.h » ('j') | Source/core/css/resolver/ElementStyleResources.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698