Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/ListStyleInterpolationTest.cpp ('k') | Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp » ('j') | Source/core/core.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp

diff --git a/Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp b/Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp

index 716a643a9a16385711e0ef9dcee351683be5d1b0..df4055ce54094d096b334c21f32c5a19473d3888 100644

--- a/Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp

+++ b/Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp

@@ -42,7 +42,7 @@ bool SVGStrokeDasharrayStyleInterpolation::canCreateFrom(const CSSValue& value)

const CSSValueList& valueList = toCSSValueList(value);

for (size_t index = 0; index < valueList.length(); ++index) {

- if (!LengthStyleInterpolation::canCreateFrom(*valueList.item(index)))

+ if (!LengthStyleInterpolation::canCreateFrom(valueList.item(index)))

return false;

}

return true;

@@ -65,8 +65,8 @@ PassRefPtrWillBeRawPtr<SVGStrokeDasharrayStyleInterpolation> SVGStrokeDasharrayS

OwnPtrWillBeRawPtr<InterpolableList> interpolableEnd = InterpolableList::create(size);

for (size_t i = 0; i < size; ++i) {

- const CSSPrimitiveValue& from = *toCSSPrimitiveValue(valueListStart.item(i % valueListStart.length()));

- const CSSPrimitiveValue& to = *toCSSPrimitiveValue(valueListEnd.item(i % valueListEnd.length()));

+ const CSSValue from = valueListStart.item(i % valueListStart.length());

+ const CSSValue to = valueListEnd.item(i % valueListEnd.length());

interpolableStart->set(i, LengthStyleInterpolation::toInterpolableValue(from));

interpolableEnd->set(i, LengthStyleInterpolation::toInterpolableValue(to));