CSSValue Immediates: Change CSSValue to an object instead of a pointer

Source/core/css/resolver/ElementStyleResources.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 19 matching lines @@
 #include "core/style/StylePendingImage.h"
 #include "platform/graphics/filters/FilterOperation.h"
 
 namespace blink {
 
 ElementStyleResources::ElementStyleResources()
     : m_deviceScaleFactor(1)
 {
 }
 
-PassRefPtr<StyleImage> ElementStyleResources::styleImage(Document& document, const TextLinkColors& textLinkColors, Color currentColor, CSSPropertyID property, CSSValue* value)
+PassRefPtr<StyleImage> ElementStyleResources::styleImage(Document& document, const TextLinkColors& textLinkColors, Color currentColor, CSSPropertyID property, CSSValue value)
 {
-    if (value->isImageValue())
+    if (value.isImageValue())
         return cachedOrPendingFromValue(document, property, toCSSImageValue(value));
 
-    if (value->isImageGeneratorValue())
-        return generatedOrPendingFromValue(property, toCSSImageGeneratorValue(value));
+    if (value.isImageGeneratorValue())
+        return generatedOrPendingFromValue(property, &toCSSImageGeneratorValue(value));
 
-    if (value->isImageSetValue())
+    if (value.isImageSetValue())
         return setOrPendingFromValue(property, toCSSImageSetValue(value));
 
-    if (value->isCursorImageValue())
+    if (value.isCursorImageValue())
         return cursorOrPendingFromValue(property, toCSSCursorImageValue(value));
 
     return nullptr;
 }
 
 PassRefPtr<StyleImage> ElementStyleResources::generatedOrPendingFromValue(CSSPropertyID property, CSSImageGeneratorValue* value)
 {
     if (value->isPending()) {
         m_pendingImageProperties.set(property, value);
         return StylePendingImage::create(value);
     }
     return StyleGeneratedImage::create(value);
 }
 
-PassRefPtr<StyleImage> ElementStyleResources::setOrPendingFromValue(CSSPropertyID property, CSSImageSetValue* value)
+PassRefPtr<StyleImage> ElementStyleResources::setOrPendingFromValue(CSSPropertyID property, CSSImageSetValue& value)
 {
-    RefPtr<StyleImage> image = value->cachedOrPendingImageSet(m_deviceScaleFactor);
+    RefPtr<StyleImage> image = value.cachedOrPendingImageSet(m_deviceScaleFactor);
     if (image && image->isPendingImage())
-        m_pendingImageProperties.set(property, value);
+        m_pendingImageProperties.set(property, &value);
     return image.release();
 }
 
-PassRefPtr<StyleImage> ElementStyleResources::cachedOrPendingFromValue(Document& document, CSSPropertyID property, CSSImageValue* value)
+PassRefPtr<StyleImage> ElementStyleResources::cachedOrPendingFromValue(Document& document, CSSPropertyID property, CSSImageValue& value)
 {
-    RefPtr<StyleImage> image = value->cachedOrPendingImage();
+    RefPtr<StyleImage> image = value.cachedOrPendingImage();
     if (image) {
         if (image->isPendingImage())
-            m_pendingImageProperties.set(property, value);
+            m_pendingImageProperties.set(property, &value);
         else
-            value->restoreCachedResourceIfNeeded(document);
+            value.restoreCachedResourceIfNeeded(document);
     }
     return image.release();
 }
 
-PassRefPtr<StyleImage> ElementStyleResources::cursorOrPendingFromValue(CSSPropertyID property, CSSCursorImageValue* value)
+PassRefPtr<StyleImage> ElementStyleResources::cursorOrPendingFromValue(CSSPropertyID property, CSSCursorImageValue& value)
 {
-    RefPtr<StyleImage> image = value->cachedOrPendingImage(m_deviceScaleFactor);
+    RefPtr<StyleImage> image = value.cachedOrPendingImage(m_deviceScaleFactor);
     if (image && image->isPendingImage())
-        m_pendingImageProperties.set(property, value);
+        m_pendingImageProperties.set(property, &value);
     return image.release();
 }
 
 void ElementStyleResources::clearPendingImageProperties()
 {
     m_pendingImageProperties.clear();
 }
 
 void ElementStyleResources::clearPendingSVGDocuments()
 {
     m_pendingSVGDocuments.clear();
 }
 
 void ElementStyleResources::addPendingSVGDocument(FilterOperation* filterOperation, CSSSVGDocumentValue* cssSVGDocumentValue)
 {
     m_pendingSVGDocuments.set(filterOperation, cssSVGDocumentValue);
 }
 
 }