CSSValue Immediates: Change CSSValue to an object instead of a pointer

Source/core/css/CSSValueList.cpp

 /*
  * (C) 1999-2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 #include "core/css/CSSValueList.h"
 
 #include "core/css/CSSPrimitiveValue.h"
 #include "wtf/text/StringBuilder.h"
 
 namespace blink {
 
 CSSValueList::CSSValueList(ClassType classType, ValueListSeparator listSeparator)
-    : CSSValue(classType)
+    : CSSValueObject(classType)
 {
     m_valueListSeparator = listSeparator;
 }
 
 CSSValueList::CSSValueList(ValueListSeparator listSeparator)
-    : CSSValue(ValueListClass)
+    : CSSValueObject(ValueListClass)
 {
     m_valueListSeparator = listSeparator;
 }
 
-bool CSSValueList::removeAll(CSSValue* val)
+bool CSSValueList::removeAll(CSSValue val)
 {
     bool found = false;
     for (int index = m_values.size() - 1; index >= 0; --index) {
-        RefPtrWillBeMember<CSSValue>& value = m_values.at(index);
-        if (value && val && value->equals(*val)) {
+        CSSValue& value = m_values.at(index);
+        if (value.equals(val)) {
             m_values.remove(index);
             found = true;
         }
     }
 
     return found;
 }
 
-bool CSSValueList::hasValue(CSSValue* val) const
+bool CSSValueList::hasValue(CSSValue val) const
 {
     for (size_t index = 0; index < m_values.size(); index++) {
-        const RefPtrWillBeMember<CSSValue>& value = m_values.at(index);
-        if (value && val && value->equals(*val))
+        const CSSValue& value = m_values.at(index);
+        if (value.equals(val))
             return true;
     }
     return false;
 }
 
 PassRefPtrWillBeRawPtr<CSSValueList> CSSValueList::copy()
 {
     RefPtrWillBeRawPtr<CSSValueList> newList = nullptr;
     switch (m_valueListSeparator) {
     case SpaceSeparator:
@@ skipping 28 matching lines @@
         separator = " / ";
         break;
     default:
         ASSERT_NOT_REACHED();
     }
 
     unsigned size = m_values.size();
     for (unsigned i = 0; i < size; i++) {
         if (!result.isEmpty())
             result.append(separator);
-        result.append(m_values[i]->cssText());
+        result.append(m_values[i].cssText());
     }
 
     return result.toString();
 }
 
 bool CSSValueList::equals(const CSSValueList& other) const
 {
     return m_valueListSeparator == other.m_valueListSeparator && compareCSSValueVector(m_values, other.m_values);
 }
 
 bool CSSValueList::hasFailedOrCanceledSubresources() const
 {
     for (unsigned i = 0; i < m_values.size(); ++i) {
-        if (m_values[i]->hasFailedOrCanceledSubresources())
+        if (m_values[i].hasFailedOrCanceledSubresources())
             return true;
     }
     return false;
 }
 
 DEFINE_TRACE_AFTER_DISPATCH(CSSValueList)
 {
-    visitor->trace(m_values);
-    CSSValue::traceAfterDispatch(visitor);
+    for (unsigned i = 0; i < m_values.size(); ++i) {
+        visitor->trace(m_values[i]);
+    }
+    CSSValueObject::traceAfterDispatch(visitor);
 }
 
 } // namespace blink