Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: Source/core/css/CSSImageGeneratorValue.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 , count(newCount) 44 , count(newCount)
45 { 45 {
46 } 46 }
47 47
48 IntSize size; 48 IntSize size;
49 int count; 49 int count;
50 }; 50 };
51 51
52 typedef HashMap<const LayoutObject*, SizeAndCount> LayoutObjectSizeCountMap; 52 typedef HashMap<const LayoutObject*, SizeAndCount> LayoutObjectSizeCountMap;
53 53
54 class CORE_EXPORT CSSImageGeneratorValue : public CSSValue { 54 class CORE_EXPORT CSSImageGeneratorValue : public CSSValueObject {
55 public: 55 public:
56 ~CSSImageGeneratorValue(); 56 ~CSSImageGeneratorValue();
57 57
58 void addClient(LayoutObject*, const IntSize&); 58 void addClient(LayoutObject*, const IntSize&);
59 void removeClient(LayoutObject*); 59 void removeClient(LayoutObject*);
60 PassRefPtr<Image> image(LayoutObject*, const IntSize&); 60 PassRefPtr<Image> image(LayoutObject*, const IntSize&);
61 61
62 bool isFixedSize() const; 62 bool isFixedSize() const;
63 IntSize fixedSize(const LayoutObject*); 63 IntSize fixedSize(const LayoutObject*);
64 64
65 bool isPending() const; 65 bool isPending() const;
66 bool knownToBeOpaque(const LayoutObject*) const; 66 bool knownToBeOpaque(const LayoutObject*) const;
67 67
68 void loadSubimages(Document*); 68 void loadSubimages(Document*);
69 69
70 DEFINE_INLINE_TRACE_AFTER_DISPATCH() { CSSValue::traceAfterDispatch(visitor) ; } 70 DEFINE_INLINE_TRACE_AFTER_DISPATCH() { CSSValueObject::traceAfterDispatch(vi sitor); }
71 71
72 protected: 72 protected:
73 explicit CSSImageGeneratorValue(ClassType); 73 explicit CSSImageGeneratorValue(ClassType);
74 74
75 Image* getImage(LayoutObject*, const IntSize&); 75 Image* getImage(LayoutObject*, const IntSize&);
76 void putImage(const IntSize&, PassRefPtr<Image>); 76 void putImage(const IntSize&, PassRefPtr<Image>);
77 const LayoutObjectSizeCountMap& clients() const { return m_clients; } 77 const LayoutObjectSizeCountMap& clients() const { return m_clients; }
78 78
79 HashCountedSet<IntSize> m_sizes; // A count of how many times a given image size is in use. 79 HashCountedSet<IntSize> m_sizes; // A count of how many times a given image size is in use.
80 LayoutObjectSizeCountMap m_clients; // A map from LayoutObjects (with entry count) to image sizes. 80 LayoutObjectSizeCountMap m_clients; // A map from LayoutObjects (with entry count) to image sizes.
81 HashMap<IntSize, RefPtr<Image>> m_images; // A cache of Image objects by ima ge size. 81 HashMap<IntSize, RefPtr<Image>> m_images; // A cache of Image objects by ima ge size.
82 82
83 #if ENABLE(OILPAN) 83 #if ENABLE(OILPAN)
84 // FIXME: Oilpan: when/if we can make the layoutObject point directly to the CSSImageGenerator value using 84 // FIXME: Oilpan: when/if we can make the layoutObject point directly to the CSSImageGenerator value using
85 // a member we don't need to have this hack where we keep a persistent to th e instance as long as 85 // a member we don't need to have this hack where we keep a persistent to th e instance as long as
86 // there are clients in the LayoutObjectSizeCountMap. 86 // there are clients in the LayoutObjectSizeCountMap.
87 GC_PLUGIN_IGNORE("366546") 87 GC_PLUGIN_IGNORE("366546")
88 OwnPtr<Persistent<CSSImageGeneratorValue>> m_keepAlive; 88 OwnPtr<Persistent<CSSImageGeneratorValue>> m_keepAlive;
89 #endif 89 #endif
90 }; 90 };
91 91
92 DEFINE_CSS_VALUE_TYPE_CASTS(CSSImageGeneratorValue, isImageGeneratorValue()); 92 DEFINE_CSS_VALUE_TYPE_CASTS(CSSImageGeneratorValue, isImageGeneratorValue());
93 93
94 } // namespace blink 94 } // namespace blink
95 95
96 #endif // CSSImageGeneratorValue_h 96 #endif // CSSImageGeneratorValue_h
OLDNEW
« no previous file with comments | « Source/core/css/CSSGridTemplateAreasValue.cpp ('k') | Source/core/css/CSSImageGeneratorValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698