CSSValue Immediates: Change CSSValue to an object instead of a pointer

Source/core/css/CSSGradientValue.cpp

 /*
  * Copyright (C) 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2015 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 174 matching lines @@
             newStops[y].color = blend(leftColor, rightColor, weighting);
         }
 
         // Replace the color hint with the new color stops.
         stops.remove(x);
         stops.insert(x, newStops, 9);
         indexOffset += 8;
     }
 }
 
-static Color resolveStopColor(CSSPrimitiveValue* stopColor, const LayoutObject& object)
+static Color resolveStopColor(CSSPrimitiveValue& stopColor, const LayoutObject& object)
 {
     return object.document().textLinkColors().colorFromPrimitiveValue(stopColor, object.resolveColor(CSSPropertyColor));
 }
 
 void CSSGradientValue::addDeprecatedStops(Gradient* gradient, const LayoutObject& object)
 {
     ASSERT(m_gradientType == CSSDeprecatedLinearGradient || m_gradientType == CSSDeprecatedRadialGradient);
 
     if (!m_stopsSorted) {
         if (m_stops.size())
             std::stable_sort(m_stops.begin(), m_stops.end(), compareStops);
         m_stopsSorted = true;
     }
 
     for (const auto& stop : m_stops) {
         float offset;
         if (stop.m_position->isPercentage())
             offset = stop.m_position->getFloatValue() / 100;
         else
             offset = stop.m_position->getFloatValue();
 
-        gradient->addColorStop(offset, resolveStopColor(stop.m_color.get(), object));
+        gradient->addColorStop(offset, resolveStopColor(*stop.m_color.get(), object));
     }
 }
 
 static bool requiresStopsNormalization(const Vector<GradientStop>& stops, const Gradient* gradient)
 {
     // We need at least two stops to normalize
     if (stops.size() < 2)
         return false;
 
     // Repeating gradients are implemented using a normalized stop offset range
@@ skipping 141 matching lines @@
     else if (isRadialGradientValue())
         gradientEnd = gradientStart + FloatSize(gradient->endRadius(), 0);
     float gradientLength = FloatSize(gradientStart - gradientEnd).diagonalLength();
 
     for (size_t i = 0; i < numStops; ++i) {
         const CSSGradientColorStop& stop = m_stops[i];
 
         if (stop.isHint())
             hasHints = true;
         else
-            stops[i].color = resolveStopColor(stop.m_color.get(), object);
+            stops[i].color = resolveStopColor(*stop.m_color.get(), object);
 
         if (stop.m_position) {
             if (stop.m_position->isPercentage())
                 stops[i].offset = stop.m_position->getFloatValue() / 100;
             else if (stop.m_position->isLength() || stop.m_position->isCalculatedPercentageWithLength()) {
                 float length;
                 if (stop.m_position->isLength())
                     length = stop.m_position->computeLength<float>(conversionData);
                 else
                     length = stop.m_position->cssCalcValue()->toCalcValue(conversionData)->evaluate(gradientLength);
@@ skipping 166 matching lines @@
             return false;
     }
 
     return true;
 }
 
 bool CSSGradientValue::knownToBeOpaque(const LayoutObject* object) const
 {
     ASSERT(object);
     for (auto& stop : m_stops) {
-        if (!stop.isHint() && resolveStopColor(stop.m_color.get(), *object).hasAlpha())
+        if (!stop.isHint() && resolveStopColor(*stop.m_color.get(), *object).hasAlpha())
             return false;
     }
     return true;
 }
 
 DEFINE_TRACE_AFTER_DISPATCH(CSSGradientValue)
 {
 #if ENABLE(OILPAN)
     visitor->trace(m_firstX);
     visitor->trace(m_firstY);
@@ skipping 627 matching lines @@
     visitor->trace(m_firstRadius);
     visitor->trace(m_secondRadius);
     visitor->trace(m_shape);
     visitor->trace(m_sizingBehavior);
     visitor->trace(m_endHorizontalSize);
     visitor->trace(m_endVerticalSize);
     CSSGradientValue::traceAfterDispatch(visitor);
 }
 
 } // namespace blink