Source/core/css/PropertySetCSSStyleDeclaration.h - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Side by Side Diff: Source/core/css/PropertySetCSSStyleDeclaration.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase and oilpan feedback Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/css/CSSValue.h ('K') | « Source/core/css/FontFace.cpp ('k') | Source/core/css/PropertySetCSSStyleDeclaration.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Apple Inc. All rights reserved.	2 * Copyright (C) 2012 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 virtual unsigned length() const override final;	51 virtual unsigned length() const override final;

52 virtual String item(unsigned index) const override final;	52 virtual String item(unsigned index) const override final;

53 virtual String getPropertyValue(const String& propertyName) override final;	53 virtual String getPropertyValue(const String& propertyName) override final;

54 virtual String getPropertyPriority(const String& propertyName) override fina l;	54 virtual String getPropertyPriority(const String& propertyName) override fina l;

55 virtual String getPropertyShorthand(const String& propertyName) override fin al;	55 virtual String getPropertyShorthand(const String& propertyName) override fin al;

56 virtual bool isPropertyImplicit(const String& propertyName) override final;	56 virtual bool isPropertyImplicit(const String& propertyName) override final;

57 virtual void setProperty(const String& propertyName, const String& value, co nst String& priority, ExceptionState&) override final;	57 virtual void setProperty(const String& propertyName, const String& value, co nst String& priority, ExceptionState&) override final;

58 virtual String removeProperty(const String& propertyName, ExceptionState&) o verride final;	58 virtual String removeProperty(const String& propertyName, ExceptionState&) o verride final;

59 virtual String cssText() const override final;	59 virtual String cssText() const override final;

60 virtual void setCSSText(const String&, ExceptionState&) override final;	60 virtual void setCSSText(const String&, ExceptionState&) override final;

61 virtual PassRefPtrWillBeRawPtr<CSSValue> getPropertyCSSValueInternal(CSSProp ertyID) override final;	61 virtual NullableCSSValue getPropertyCSSValueInternal(CSSPropertyID) override final;

62 virtual String getPropertyValueInternal(CSSPropertyID) override final;	62 virtual String getPropertyValueInternal(CSSPropertyID) override final;

63 virtual void setPropertyInternal(CSSPropertyID, const String& value, bool im portant, ExceptionState&) override final;	63 virtual void setPropertyInternal(CSSPropertyID, const String& value, bool im portant, ExceptionState&) override final;

64	64

65 virtual bool cssPropertyMatches(CSSPropertyID, const CSSValue*) const overri de final;	65 virtual bool cssPropertyMatches(CSSPropertyID, const CSSValue) const overrid e final;

66 virtual PassRefPtrWillBeRawPtr<MutableStylePropertySet> copyProperties() con st override final;	66 virtual PassRefPtrWillBeRawPtr<MutableStylePropertySet> copyProperties() con st override final;

67	67

68 protected:	68 protected:

69 enum MutationType { NoChanges, PropertyChanged };	69 enum MutationType { NoChanges, PropertyChanged };

70 virtual void willMutate() { }	70 virtual void willMutate() { }

71 virtual void didMutate(MutationType) { }	71 virtual void didMutate(MutationType) { }

72 virtual MutableStylePropertySet& propertySet() const = 0;	72 virtual MutableStylePropertySet& propertySet() const = 0;

73 };	73 };

74	74

75 class PropertySetCSSStyleDeclaration : public AbstractPropertySetCSSStyleDeclara tion {	75 class PropertySetCSSStyleDeclaration : public AbstractPropertySetCSSStyleDeclara tion {

(...skipping 69 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
145 virtual Element* parentElement() const override { return m_parentElement; }	145 virtual Element* parentElement() const override { return m_parentElement; }

146	146

147 virtual void didMutate(MutationType) override;	147 virtual void didMutate(MutationType) override;

148	148

149 RawPtrWillBeMember<Element> m_parentElement;	149 RawPtrWillBeMember<Element> m_parentElement;

150 };	150 };

151	151

152 } // namespace blink	152 } // namespace blink

153	153

154 #endif	154 #endif

OLD	NEW