Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: (Hopefully) Builds with oilpan now Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2966 matching lines...) Expand 10 before | Expand all | Expand 10 after
2977 { 2977 {
2978 if (oldDocument == newDocument) 2978 if (oldDocument == newDocument)
2979 return false; 2979 return false;
2980 if (oldDocument.baseURL() == newDocument.baseURL()) 2980 if (oldDocument.baseURL() == newDocument.baseURL())
2981 return false; 2981 return false;
2982 const StylePropertySet* style = element.inlineStyle(); 2982 const StylePropertySet* style = element.inlineStyle();
2983 if (!style) 2983 if (!style)
2984 return false; 2984 return false;
2985 for (unsigned i = 0; i < style->propertyCount(); ++i) { 2985 for (unsigned i = 0; i < style->propertyCount(); ++i) {
2986 // FIXME: Should handle all URL-based properties: CSSImageSetValue, CSSC ursorImageValue, etc. 2986 // FIXME: Should handle all URL-based properties: CSSImageSetValue, CSSC ursorImageValue, etc.
2987 if (style->propertyAt(i).value()->isImageValue()) 2987 if (style->propertyAt(i).value().isImageValue())
2988 return true; 2988 return true;
2989 } 2989 }
2990 return false; 2990 return false;
2991 } 2991 }
2992 2992
2993 static void reResolveURLsInInlineStyle(const Document& document, MutableStylePro pertySet& style) 2993 static void reResolveURLsInInlineStyle(const Document& document, MutableStylePro pertySet& style)
2994 { 2994 {
2995 for (unsigned i = 0; i < style.propertyCount(); ++i) { 2995 for (unsigned i = 0; i < style.propertyCount(); ++i) {
2996 StylePropertySet::PropertyReference property = style.propertyAt(i); 2996 StylePropertySet::PropertyReference property = style.propertyAt(i);
2997 // FIXME: Should handle all URL-based properties: CSSImageSetValue, CSSC ursorImageValue, etc. 2997 // FIXME: Should handle all URL-based properties: CSSImageSetValue, CSSC ursorImageValue, etc.
2998 if (property.value()->isImageValue()) 2998 if (property.value().isImageValue())
2999 toCSSImageValue(property.value())->reResolveURL(document); 2999 toCSSImageValue(property.value()).reResolveURL(document);
3000 } 3000 }
3001 } 3001 }
3002 3002
3003 void Element::didMoveToNewDocument(Document& oldDocument) 3003 void Element::didMoveToNewDocument(Document& oldDocument)
3004 { 3004 {
3005 Node::didMoveToNewDocument(oldDocument); 3005 Node::didMoveToNewDocument(oldDocument);
3006 3006
3007 // If the documents differ by quirks mode then they differ by case sensitivi ty 3007 // If the documents differ by quirks mode then they differ by case sensitivi ty
3008 // for class and id names so we need to go through the attribute change logi c 3008 // for class and id names so we need to go through the attribute change logi c
3009 // to pick up the new casing in the ElementData. 3009 // to pick up the new casing in the ElementData.
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after
3388 { 3388 {
3389 #if ENABLE(OILPAN) 3389 #if ENABLE(OILPAN)
3390 if (hasRareData()) 3390 if (hasRareData())
3391 visitor->trace(elementRareData()); 3391 visitor->trace(elementRareData());
3392 visitor->trace(m_elementData); 3392 visitor->trace(m_elementData);
3393 #endif 3393 #endif
3394 ContainerNode::trace(visitor); 3394 ContainerNode::trace(visitor);
3395 } 3395 }
3396 3396
3397 } // namespace blink 3397 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698