Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: (Hopefully) Builds with oilpan now Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/animation/animatable/AnimatableUnknownTest.cpp ('K') | « Source/core/animation/animatable/AnimatableValueTestHelper.cpp ('k') | Source/core/animation/css/CSSAnimatableValueFactory.cpp » ('j') | Source/core/css/CSSValue.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2013, Google Inc. All rights reserved.	2 * Copyright (c) 2013, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 77 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
88 PrintToString(AnimatableTransform::create(operations1)));	88 PrintToString(AnimatableTransform::create(operations1)));

89	89

90 TransformOperations operations2;	90 TransformOperations operations2;

91 operations2.operations().append(ScaleTransformOperation::create(1, 1, 1, Tra nsformOperation::Scale3D));	91 operations2.operations().append(ScaleTransformOperation::create(1, 1, 1, Tra nsformOperation::Scale3D));

92 EXPECT_EQ(	92 EXPECT_EQ(

93 ::std::string("AnimatableTransform([1 0 0 1 0 0])"),	93 ::std::string("AnimatableTransform([1 0 0 1 0 0])"),

94 PrintToString(AnimatableTransform::create(operations2)));	94 PrintToString(AnimatableTransform::create(operations2)));

95	95

96 EXPECT_EQ(	96 EXPECT_EQ(

97 ::std::string("AnimatableUnknown(none)"),	97 ::std::string("AnimatableUnknown(none)"),

98 PrintToString(AnimatableUnknown::create(CSSPrimitiveValue::createIdentif ier(CSSValueNone).get())));	98 PrintToString(AnimatableUnknown::create(CSSPrimitiveValue::createIdentif ier(CSSValueNone))));

99	99

100 EXPECT_EQ(	100 EXPECT_EQ(

101 ::std::string("AnimatableVisibility(VISIBLE)"),	101 ::std::string("AnimatableVisibility(VISIBLE)"),

102 PrintToString(AnimatableVisibility::create(VISIBLE)));	102 PrintToString(AnimatableVisibility::create(VISIBLE)));

103 }	103 }

104	104

105 } // namespace	105 } // namespace

OLD	NEW