Source/core/paint/InlineFlowBoxPainter.h - Issue 1164553003: [SP] Pass correct cull rect to fix horizontal box shadow painting at tile edge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/InlineFlowBoxPainter.h

Issue 1164553003: [SP] Pass correct cull rect to fix horizontal box shadow painting at tile edge. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Disable vertical-rl layout test as we'll fix it in next change. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/writing-mode/box-shadow-horizontal-tb-tile-edge.html ('k') | Source/core/paint/InlineFlowBoxPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/InlineFlowBoxPainter.h

diff --git a/Source/core/paint/InlineFlowBoxPainter.h b/Source/core/paint/InlineFlowBoxPainter.h

index e06f514d68bf67ea83bedca0fc48e3c73fc45912..ae04f6531a956cb790443fd8ca4f54fd3948248b 100644

--- a/Source/core/paint/InlineFlowBoxPainter.h

+++ b/Source/core/paint/InlineFlowBoxPainter.h

@@ -24,16 +24,16 @@ class ComputedStyle;

class InlineFlowBoxPainter {

public:

InlineFlowBoxPainter(InlineFlowBox& inlineFlowBox) : m_inlineFlowBox(inlineFlowBox) { }

- void paint(const PaintInfo&, const LayoutPoint&, const LayoutUnit lineTop, const LayoutUnit lineBottom);

+ void paint(const PaintInfo&, const LayoutPoint& paintOffset, const LayoutUnit lineTop, const LayoutUnit lineBottom);

private:

- void paintBoxDecorationBackground(const PaintInfo&, const LayoutPoint&);

- void paintMask(const PaintInfo&, const LayoutPoint&);

- void paintFillLayers(const PaintInfo&, const Color&, const FillLayer&, const LayoutRect&, SkXfermode::Mode = SkXfermode::kSrcOver_Mode);

- void paintFillLayer(const PaintInfo&, const Color&, const FillLayer&, const LayoutRect&, SkXfermode::Mode);

- void paintBoxShadow(const PaintInfo&, const ComputedStyle&, ShadowStyle, const LayoutRect&);

+ void paintBoxDecorationBackground(const PaintInfo&, const LayoutPoint& paintOffset, const LayoutRect& cullRect);

+ void paintMask(const PaintInfo&, const LayoutPoint& paintOffset);

+ void paintFillLayers(const PaintInfo&, const Color&, const FillLayer&, const LayoutRect&, SkXfermode::Mode op = SkXfermode::kSrcOver_Mode);

+ void paintFillLayer(const PaintInfo&, const Color&, const FillLayer&, const LayoutRect&, SkXfermode::Mode op);

+ void paintBoxShadow(const PaintInfo&, const ComputedStyle&, ShadowStyle, const LayoutRect& paintRect);

LayoutRect roundedFrameRectClampedToLineTopAndBottomIfNeeded() const;

- LayoutRect paintRectForImageStrip(const LayoutPoint&, const LayoutSize&, TextDirection) const;

+ LayoutRect paintRectForImageStrip(const LayoutPoint& paintOffset, const LayoutSize& frameSize, TextDirection) const;

enum BorderPaintingType {

DontPaintBorders,