Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1164553003: [SP] Pass correct cull rect to fix horizontal box shadow painting at tile edge. (Closed)

Created:
4 years, 11 months ago by wkorman
Modified:
4 years, 11 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[SP] Pass correct cull rect to fix horizontal box shadow painting at tile edge. BUG=472330 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196363

Patch Set 1 #

Patch Set 2 : Merge changes. #

Total comments: 2

Patch Set 3 : Restore actual use of the cull rect. #

Patch Set 4 : Add param names for documentation. #

Patch Set 5 : Disable vertical-rl layout test as we'll fix it in next change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -10 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/writing-mode/box-shadow-horizontal-bt-tile-edge.html View 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/fast/writing-mode/box-shadow-horizontal-tb-tile-edge.html View 1 chunk +23 lines, -0 lines 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.h View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
wkorman
4 years, 11 months ago (2015-06-02 21:04:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164553003/20001
4 years, 11 months ago (2015-06-02 21:08:29 UTC) #4
chrishtr
https://codereview.chromium.org/1164553003/diff/20001/Source/core/paint/InlineFlowBoxPainter.h File Source/core/paint/InlineFlowBoxPainter.h (right): https://codereview.chromium.org/1164553003/diff/20001/Source/core/paint/InlineFlowBoxPainter.h#newcode30 Source/core/paint/InlineFlowBoxPainter.h:30: void paintBoxDecorationBackground(const PaintInfo&, const LayoutPoint&, const LayoutRect&); Give the ...
4 years, 11 months ago (2015-06-02 21:17:33 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164553003/40001
4 years, 11 months ago (2015-06-02 21:17:55 UTC) #8
wkorman
https://codereview.chromium.org/1164553003/diff/20001/Source/core/paint/InlineFlowBoxPainter.h File Source/core/paint/InlineFlowBoxPainter.h (right): https://codereview.chromium.org/1164553003/diff/20001/Source/core/paint/InlineFlowBoxPainter.h#newcode30 Source/core/paint/InlineFlowBoxPainter.h:30: void paintBoxDecorationBackground(const PaintInfo&, const LayoutPoint&, const LayoutRect&); On 2015/06/02 ...
4 years, 11 months ago (2015-06-02 21:39:47 UTC) #9
chrishtr
lgtm
4 years, 11 months ago (2015-06-02 21:40:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164553003/60001
4 years, 11 months ago (2015-06-02 21:41:55 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64563)
4 years, 11 months ago (2015-06-02 23:57:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164553003/80001
4 years, 11 months ago (2015-06-03 01:02:56 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 02:43:28 UTC) #18
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196363

Powered by Google App Engine
This is Rietveld 408576698