Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1164533007: Remove the redundant HTMLDocument.compatMode (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, arv+blink, vivekg_samsung, blink-reviews-html_chromium.org, vivekg, dglazkov+blink, Inactive
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove the redundant HTMLDocument.compatMode Since Document.compatMode is defined identically and the implementation is in Document::compatMode(), the only consequence of this is that the compatMode attribute goes away from the HTMLDocument prototype. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLDocument.idl View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164533007/1
5 years, 6 months ago (2015-06-05 23:02:36 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-06 00:12:30 UTC) #4
philipj_slow
PTAL
5 years, 6 months ago (2015-06-06 06:29:20 UTC) #6
Jens Widell
LGTM
5 years, 6 months ago (2015-06-06 06:36:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164533007/1
5 years, 6 months ago (2015-06-06 06:39:40 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-06 06:44:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196624

Powered by Google App Engine
This is Rietveld 408576698