Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: runtime/bin/dbg_message.cc

Issue 11645046: Fix an issue with newlines and exception text in the debugger wire protocol. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/VmConnection.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dbg_message.cc
===================================================================
--- runtime/bin/dbg_message.cc (revision 16349)
+++ runtime/bin/dbg_message.cc (working copy)
@@ -126,11 +126,10 @@
static void FormatErrorMsg(dart::TextBuffer* buf, Dart_Handle err) {
- // TODO(hausner): Turn message into Dart string and
- // properly encode the message.
ASSERT(Dart_IsError(err));
const char* msg = Dart_GetError(err);
- buf->Printf("\"%s\"", msg);
+ Dart_Handle str = Dart_NewStringFromCString(msg);
+ FormatEncodedString(buf, str);
}
« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/VmConnection.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698