Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 11645034: Make qcms compile on Win64 (Closed)

Created:
8 years ago by jschuh
Modified:
8 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -14 lines) Patch
M third_party/qcms/README.chromium View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/qcms/google.patch View 4 chunks +92 lines, -2 lines 0 comments Download
M third_party/qcms/src/iccread.c View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/qcms/src/transform_util.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/qcms/src/transform_util.c View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jschuh
8 years ago (2012-12-20 15:40:16 UTC) #1
Evan Stade
lgtm https://codereview.chromium.org/11645034/diff/6006/third_party/qcms/README.chromium File third_party/qcms/README.chromium (right): https://codereview.chromium.org/11645034/diff/6006/third_party/qcms/README.chromium#newcode32 third_party/qcms/README.chromium:32: - Make compile clean on Win64. it's not ...
8 years ago (2012-12-20 21:20:54 UTC) #2
jschuh
https://codereview.chromium.org/11645034/diff/6006/third_party/qcms/README.chromium File third_party/qcms/README.chromium (right): https://codereview.chromium.org/11645034/diff/6006/third_party/qcms/README.chromium#newcode32 third_party/qcms/README.chromium:32: - Make compile clean on Win64. On 2012/12/20 21:20:54, ...
8 years ago (2012-12-20 22:22:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/11645034/10003
8 years ago (2012-12-20 22:25:26 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-21 00:36:17 UTC) #5
Message was sent while issue was closed.
Change committed as 174294

Powered by Google App Engine
This is Rietveld 408576698