Fix flakyness in webRequest API tests

Fix flakyness in webRequest API tests

The callback function of chrome.tabs.create is called once the tab is created, not when it is loaded.

If runTests() is called, it would open a tab for URL about:blank and once that is created, run the tests. The tests may call navigateAndWait which performs a navigation and waits for the completion. The chrome.tabs.onUpdated listener could be triggered by the completion of loading about:blank, however. Not by the completion of loading the URL which navigateAndWait tried to load. With this change, we wait until about:blank is fully loaded until we start executing any tests.

BUG=112155
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175966

[battre, 2012-12-19 17:57:57]

Hi Matt,

please review this CL.

Thanks,
Dominic

https://codereview.chromium.org/11645021/diff/1/chrome/test/data/extensions/a...
File chrome/test/data/extensions/api_test/webrequest/framework.js (right):

https://codereview.chromium.org/11645021/diff/1/chrome/test/data/extensions/a...
chrome/test/data/extensions/api_test/webrequest/framework.js:174: var retval;
we assign retval in 176 to a global variable without this. That's wrong.

[Matt Perry, 2013-01-03 23:39:30]

lgtm

https://codereview.chromium.org/11645021/diff/1/chrome/test/data/extensions/a...
File chrome/test/data/extensions/api_test/webrequest/framework.js (right):

https://codereview.chromium.org/11645021/diff/1/chrome/test/data/extensions/a...
chrome/test/data/extensions/api_test/webrequest/framework.js:42:
chrome.tabs.create({url: "about:blank"});
wow this API sucks :)

[commit-bot: I haz the power, 2013-01-07 14:36:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/11645021/1

[commit-bot: I haz the power, 2013-01-07 14:49:03]

Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests,
unit_tests

[commit-bot: I haz the power, 2013-01-07 15:34:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/11645021/1

[commit-bot: I haz the power, 2013-01-07 16:43:17]

Retried try job too often on win_aura for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2013-01-07 19:11:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/11645021/1

[commit-bot: I haz the power, 2013-01-07 21:21:32]

Retried try job too often on win_aura for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2013-01-07 23:28:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/11645021/1

[commit-bot: I haz the power, 2013-01-09 22:47:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/11645021/1

[commit-bot: I haz the power, 2013-01-10 01:25:50]

Change committed as 175966