Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 11645006: UnboxDouble: convert smi constants to doubles at compile time instead of at runtime. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 16291)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -192,7 +192,17 @@
const intptr_t deopt_id = (deopt_target != NULL) ?
deopt_target->DeoptimizationTarget() : Isolate::kNoDeoptId;
ASSERT((deopt_target != NULL) || (def->GetPropagatedCid() == kDoubleCid));
- converted = new UnboxDoubleInstr(new Value(def), deopt_id);
+ if (def->IsConstant() && def->AsConstant()->value().IsSmi()) {
+ const double dbl_val =
+ Smi::Cast(def->AsConstant()->value()).AsDoubleValue();
+ const Double& dbl_obj =
+ Double::ZoneHandle(Double::New(dbl_val, Heap::kOld));
+ ConstantInstr* double_const = new ConstantInstr(dbl_obj);
+ InsertBefore(instr, double_const, NULL, Definition::kValue);
+ converted = new UnboxDoubleInstr(new Value(double_const), deopt_id);
+ } else {
+ converted = new UnboxDoubleInstr(new Value(def), deopt_id);
+ }
}
ASSERT(converted != NULL);
InsertBefore(instr, converted, use->instruction()->env(),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698