net/proxy/proxy_resolver_v8.cc - Issue 1164483003: Allow startup with missing V8 snapshot file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_resolver_v8.cc

Issue 1164483003: Allow startup with missing V8 snapshot file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add natives_fd_exists and snapshot_fd_exists instead of checking for -1 Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_resolver_v8.cc

diff --git a/net/proxy/proxy_resolver_v8.cc b/net/proxy/proxy_resolver_v8.cc

index 590f63aa301e374a9488879123a5dd676c9de9a3..7026823f26b711770ce48ac16a664a584728042a 100644

--- a/net/proxy/proxy_resolver_v8.cc

+++ b/net/proxy/proxy_resolver_v8.cc

@@ -368,6 +368,7 @@ class SharedIsolateFactory {

if (!has_initialized_v8_) {

#ifdef V8_USE_EXTERNAL_STARTUP_DATA

gin::V8Initializer::LoadV8Snapshot();

+ gin::V8Initializer::LoadV8Natives();

#endif

gin::IsolateHolder::Initialize(

« gin/v8_initializer.cc ('K') | « media/blink/run_all_unittests.cc ('k') | no next file » | no next file with comments »