gin/test/v8_test.cc - Issue 1164483003: Allow startup with missing V8 snapshot file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/test/v8_test.cc

Issue 1164483003: Allow startup with missing V8 snapshot file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add natives_fd_exists and snapshot_fd_exists instead of checking for -1 Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/test/v8_test.cc

diff --git a/gin/test/v8_test.cc b/gin/test/v8_test.cc

index aad291d895756670ff39c519c53f69e6036f9392..cec4fc899df8c3e547b0ae1aef82c04c8d583a3c 100644

--- a/gin/test/v8_test.cc

+++ b/gin/test/v8_test.cc

@@ -23,6 +23,7 @@ V8Test::~V8Test() {

void V8Test::SetUp() {

#ifdef V8_USE_EXTERNAL_STARTUP_DATA

gin::V8Initializer::LoadV8Snapshot();

+ gin::V8Initializer::LoadV8Natives();

#endif

gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,

gin::ArrayBufferAllocator::SharedInstance());