extensions/shell/browser/shell_content_browser_client.h - Issue 1164483003: Allow startup with missing V8 snapshot file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_content_browser_client.h

Issue 1164483003: Allow startup with missing V8 snapshot file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add natives_fd_exists and snapshot_fd_exists instead of checking for -1 Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/shell/browser/shell_content_browser_client.h

diff --git a/extensions/shell/browser/shell_content_browser_client.h b/extensions/shell/browser/shell_content_browser_client.h

index f9d813f525c196b1c136ab259b1e43c9750f7fa6..8caad6eec8a97800695783aa82f76b9a07c1fac4 100644

--- a/extensions/shell/browser/shell_content_browser_client.h

+++ b/extensions/shell/browser/shell_content_browser_client.h

@@ -83,6 +83,8 @@ class ShellContentBrowserClient : public content::ContentBrowserClient {

#if defined(OS_POSIX) && !defined(OS_MACOSX)

base::ScopedFD v8_natives_fd_;

base::ScopedFD v8_snapshot_fd_;

+ bool natives_fd_exists() { return v8_natives_fd_ != -1; }

+ bool snapshot_fd_exists() { return v8_snapshot_fd_ != -1; }

#endif

// Owned by content::BrowserMainLoop.