components/html_viewer/ax_provider_impl_unittest.cc - Issue 1164483003: Allow startup with missing V8 snapshot file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/html_viewer/ax_provider_impl_unittest.cc

Issue 1164483003: Allow startup with missing V8 snapshot file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add natives_fd_exists and snapshot_fd_exists instead of checking for -1 Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/html_viewer/ax_provider_impl_unittest.cc

diff --git a/components/html_viewer/ax_provider_impl_unittest.cc b/components/html_viewer/ax_provider_impl_unittest.cc

index 7508f8a7b6d27d018ed977ec79d06091f98a492d..2bd19833b8903acd0393ace34e9767406508efdd 100644

--- a/components/html_viewer/ax_provider_impl_unittest.cc

+++ b/components/html_viewer/ax_provider_impl_unittest.cc

@@ -50,6 +50,7 @@ class AxProviderImplTest : public testing::Test {

: renderer_scheduler_(scheduler::RendererScheduler::Create()) {

#if defined(V8_USE_EXTERNAL_STARTUP_DATA)

gin::V8Initializer::LoadV8Snapshot();

+ gin::V8Initializer::LoadV8Natives();

#endif

blink::initialize(

new html_viewer::BlinkPlatformImpl(nullptr, renderer_scheduler_.get()));