gin/test/file_runner.cc - Issue 1164483003: Allow startup with missing V8 snapshot file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/test/file_runner.cc

Issue 1164483003: Allow startup with missing V8 snapshot file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix misplaced ifdef for Windows Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/test/file_runner.cc

diff --git a/gin/test/file_runner.cc b/gin/test/file_runner.cc

index 8ed0f2125d83775f61159638eebf04822336c530..4e84b88c3a9fc1527fa717eeed3244e82bcf086e 100644

--- a/gin/test/file_runner.cc

+++ b/gin/test/file_runner.cc

@@ -61,6 +61,7 @@ void RunTestFromFile(const base::FilePath& path, FileRunnerDelegate* delegate,

#ifdef V8_USE_EXTERNAL_STARTUP_DATA

gin::V8Initializer::LoadV8Snapshot();

+ gin::V8Initializer::LoadV8Natives();

#endif

gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,

« no previous file with comments | « gin/shell_runner_unittest.cc ('k') | gin/test/v8_test.cc » ('j') | no next file with comments »