Index: ash/shell/content_client/shell_content_browser_client.cc |
diff --git a/ash/shell/content_client/shell_content_browser_client.cc b/ash/shell/content_client/shell_content_browser_client.cc |
index 51b0107d5ad9f1b8a532e3793655f9a506b1f193..5f2adc52760962cd394b47f1db8b65686874c8ef 100644 |
--- a/ash/shell/content_client/shell_content_browser_client.cc |
+++ b/ash/shell/content_client/shell_content_browser_client.cc |
@@ -43,16 +43,17 @@ net::URLRequestContextGetter* ShellContentBrowserClient::CreateRequestContext( |
request_interceptors.Pass()); |
} |
-void ShellContentBrowserClient::AppendExtraCommandLineSwitches( |
- base::CommandLine* command_line, |
- int child_process_id) { |
+void ShellContentBrowserClient::AppendMappedFileCommandLineSwitches( |
+ base::CommandLine* command_line) { |
#if defined(OS_POSIX) && !defined(OS_MACOSX) |
#if defined(V8_USE_EXTERNAL_STARTUP_DATA) |
std::string process_type = |
command_line->GetSwitchValueASCII(switches::kProcessType); |
if (process_type != switches::kZygoteProcess) { |
+ DCHECK(natives_fd_exists()); |
command_line->AppendSwitch(::switches::kV8NativesPassedByFD); |
- command_line->AppendSwitch(::switches::kV8SnapshotPassedByFD); |
+ if (snapshot_fd_exists()) |
+ command_line->AppendSwitch(::switches::kV8SnapshotPassedByFD); |
} |
#endif // V8_USE_EXTERNAL_STARTUP_DATA |
#endif // OS_POSIX && !OS_MACOSX |
@@ -64,7 +65,7 @@ void ShellContentBrowserClient::GetAdditionalMappedFilesForChildProcess( |
int child_process_id, |
content::FileDescriptorInfo* mappings) { |
#if defined(V8_USE_EXTERNAL_STARTUP_DATA) |
- if (v8_natives_fd_.get() == -1 || v8_snapshot_fd_.get() == -1) { |
+ if (!natives_fd_exists()) { |
int v8_natives_fd = -1; |
int v8_snapshot_fd = -1; |
if (gin::V8Initializer::OpenV8FilesForChildProcesses(&v8_natives_fd, |
@@ -73,7 +74,9 @@ void ShellContentBrowserClient::GetAdditionalMappedFilesForChildProcess( |
v8_snapshot_fd_.reset(v8_snapshot_fd); |
} |
} |
- DCHECK(v8_natives_fd_.get() != -1 && v8_snapshot_fd_.get() != -1); |
+ // V8 can't start up without the source of the natives, but it can |
+ // start up (slower) without the snapshot. |
+ DCHECK(natives_fd_exists()); |
mappings->Share(kV8NativesDataDescriptor, v8_natives_fd_.get()); |
mappings->Share(kV8SnapshotDataDescriptor, v8_snapshot_fd_.get()); |
#endif // V8_USE_EXTERNAL_STARTUP_DATA |